Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated lock file version check to use new workflow #147

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Aug 25, 2023

Renamed lockfileversion-check-v3 to lockfile-check in lockfile version file.

Ticket

Prototype a way to review NPM lockfiles in PRs

@Mashal-m Mashal-m changed the title Mashal m/update lockfile refactor: update lock file version Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ce45c80) 83.01% compared to head (46c67da) 83.01%.
Report is 2 commits behind head on master.

❗ Current head 46c67da differs from pull request most recent head d5315f2. Consider uploading reports for the commit d5315f2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          46       46           
  Lines         683      683           
  Branches      132      132           
=======================================
  Hits          567      567           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m changed the title refactor: update lock file version refactor: updated lock file version check to use new workflow #834 Aug 31, 2023
@Mashal-m Mashal-m changed the title refactor: updated lock file version check to use new workflow #834 refactor: updated lock file version check to use new workflow Aug 31, 2023
@arbrandes arbrandes merged commit 7ce2a61 into master Sep 22, 2023
4 checks passed
@arbrandes arbrandes deleted the mashal-m/update_lockfile branch September 22, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants