Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codecov not running on PRs #1211

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

syedsajjadkazmii
Copy link
Contributor

Description

We noticed that codecov has stopped running on PRs after updating it to v4. https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes

This happened because tokenless uploading is unsupported in v4.

Details: openedx/wg-frontend#177

How Has This Been Tested?

This will be tested on PRs.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner April 1, 2024 06:08
@syedsajjadkazmii syedsajjadkazmii merged commit 60a6c97 into master Apr 1, 2024
5 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/fix-codecov branch April 1, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants