Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add response builder to the BFF #588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add response builder to the BFF #588

wants to merge 1 commit into from
+647 −133

Conversation

brobro10000
Copy link
Member

Description:
Add a description of your changes here.

Jira:
ENT-XXXX

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

adamstankiewicz
adamstankiewicz reviewed Nov 14, 2024
View reviewed changes
enterprise_access/apps/bffs/response_builder.py Show resolved Hide resolved
enterprise_access/apps/bffs/response_builder.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/response_builder.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/response_builder.py Show resolved Hide resolved
enterprise_access/apps/bffs/response_builder.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/tests/test_response_builders.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/tests/test_response_builders.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/tests/test_response_builders.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/response_builder.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/tests/test_response_builders.py Outdated Show resolved Hide resolved
@brobro10000 brobro10000 force-pushed the hu/ent-9638 branch 2 times, most recently from 6cbbfba to e155f13 Compare November 14, 2024 20:14
adamstankiewicz
adamstankiewicz reviewed Nov 15, 2024
View reviewed changes
enterprise_access/apps/bffs/handlers.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/handlers.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/handlers.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/response_builder.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/response_builder.py Outdated Show resolved Hide resolved
enterprise_access/apps/api_client/tests/test_utils.py Show resolved Hide resolved
enterprise_access/apps/api_client/tests/test_utils.py Show resolved Hide resolved
enterprise_access/apps/bffs/serializers.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/serializers.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/serializers.py Outdated Show resolved Hide resolved
@brobro10000 brobro10000 force-pushed the hu/ent-9638 branch 3 times, most recently from 940cd61 to 5d951c1 Compare November 15, 2024 19:47
@brobro10000 brobro10000 marked this pull request as ready for review November 15, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brobro10000 @adamstankiewicz