fix: when we fetch inter-service data in can_redeem matters for perf #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
force-pushed
the
aed/reorder-can-redeem-calls
branch
from
f2cbbb2
to
0b4576f
Compare
adamstankiewicz
approved these changes
Jul 27, 2023
| content_key, | ||
| ) | ||
|
|
||
| active_subsidy = subsidy_can_redeem_payload.get('active', False) |
There was a problem hiding this comment.
[suggestion/nit] Consider adding a code comment that this active refers to a computed property that takes into account start/expiration dates so there's less confusion between the subsidy active value versus the policy's is_active flag?
iloveagent57
force-pushed
the
aed/reorder-can-redeem-calls
branch
from
0b4576f
to
5f47d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should wait to fetch data from enterprise-subsidy until we know we actually need it.