Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Requirements Update #125

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

edx-requirements-bot
Copy link
Contributor

Python requirements update.Please review the changelogs for the upgraded packages.

Deleted obsolete pull_requests:
#124

@edx-requirements-bot edx-requirements-bot requested a review from a team December 13, 2021 03:25
Tests were failing due to receiving created and start_date in both
positional and keyword args via the init method. I've opted to just
remove the custom init method and just specify the created date
when making a DummySchedule
@Dillon-Dumesnil Dillon-Dumesnil force-pushed the jenkins/upgrade-python-requirements-30c299d branch from a0af634 to 25c31d4 Compare December 14, 2021 14:50
Copy link
Contributor

@mikix mikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet I was thinking "it's whack that dummyschedule doesn't auto-fill created like normal schedules do - I don't want tests to have to specify that" - but as discussed on slack, this seems like an easy fix to whatever the requirements update broke.

@Dillon-Dumesnil Dillon-Dumesnil merged commit 06bdd92 into master Dec 14, 2021
@Dillon-Dumesnil Dillon-Dumesnil deleted the jenkins/upgrade-python-requirements-30c299d branch December 14, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants