Fix and improve toggle docs #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds .readthedocs.yaml to fix the build.
This was referenced Aug 16, 2023
robrap
commented
Aug 17, 2023
| FLAG_FOO.is_enabled() | ||
| SWITCH_BAR.is_enabled() | ||
| SETTING_TOGGLE_BAZ.is_enabled() | ||
| FOO_FLAG.is_enabled() |
There was a problem hiding this comment.
Note to self: Add examples with new methods (e.g. is_disabled) once #293 lands.
kdmccormick
approved these changes
Aug 21, 2023
Provide recommendations around naming various toggles. Co-authored-by: Kyle McCormick <[email protected]>
robrap
force-pushed
the
robrap/update-docs
branch
from
2d1a264
to
9b9a6bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related to openedx/edx-platform#33026
Merge checklist: