Fix/adam/add edge reqs #848
Conversation
|
@adampalay local libraries are all libraries that we wrote here at edx. I think pyparsing should be added explicitly. |
|
@feanil , right, I thought one needed the "-e" in order to install libraries we've written? |
| -e common/lib/calc | ||
| -e common/lib/chem | ||
| -e common/lib/sandbox-packages | ||
| -e common/lib/symmath |
There was a problem hiding this comment.
We definitely don't want the -e here. We need the code copied into the sandbox.
|
I don't understand why we use --no-deps in production and not on dev machines, but since we do, this seems like the right fix. 👍 |
|
If |
|
I think calc is only used in xmodules, but I think it's worth adding pyparsing to edx requirements |
|
Sorry, I meant, if calc isn't used outside of sandbox. |
|
It's used for like numericalresponse, but there's never been a problem there. Something is odd about the way we install packages |
|
👍 |
* Implements celery task management openedx#848 * Implements personalinfo mask openedx#848 * Fix batch unregister * Fix review * Add auth_userprofile.meta for deletion openedx#848
…openedx#848" This reverts commit 66c2a32.
…alytics_styling Fix inline analytics close button styling.
@nedbat @cpennington
To add the correct packages to edx-sandbox, should we add pyparsing explicitly to the requirements, or should we install the local dependencies in editable mode (like https://github.com/edx/edx-platform/blob/master/requirements/edx/local.txt does)?