Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop repro unit test #6536

Conversation

chrisndodge
Copy link
Contributor

No description provided.

@chrisndodge
Copy link
Contributor Author

@ziafazal @mattdrayer here's the unit test that reproduces what @cahrens experienced today.

The trouble is that the about page as well as the course_catalog look at the 'see_exists' permissions check in access.py. 'see_exists' is a combination of can_load() and can_enroll(). can_load() is always going to return False because of unfulfilled milestones.

If the enrollment window is in the past, then can_enroll() is also going to return False, causing these 404 errors to occur.

@chrisndodge
Copy link
Contributor Author

Oh - obviously this PR is to just pass along the code - this should get merged to the main branch when these tests pass (aka the real fix is in)

EDIT: I also left in a bunch of 'print' statements to help debug the unit tests....

@mattdrayer
Copy link
Contributor

@ziafazal -- let @chrisndodge and me know if you need more clarification on what needs to be done to address this issue, thanks!

@chrisndodge
Copy link
Contributor Author

My suggestion would be to cut/paste over the unit test over to the feature branch and make sure it succeeds I think the current state of the main feature branch should be OK with respect to this reported bug. Then we can delete this PR (don't merge).

@ziafazal
Copy link
Contributor

Yeah I have already pasted the required unit test in #6126 . Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants