make asides render in studio #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLAT-280
dmitchell
force-pushed
the
dhm/studio_asides
branch
2 times, most recently
from
6ef6968
to
2318136
Compare
| from config_models.models import ConfigurationModel | ||
|
|
||
|
|
||
| class StudioConfig(ConfigurationModel): |
There was a problem hiding this comment.
So - is this a Studio-wide config? Or asides-only? The docstring above implies asides-only - but this class name implies Studio-wide. The model should be called what it actually is - to avoid confusion.
There was a problem hiding this comment.
I would have liked to see this name changed.
dmitchell
force-pushed
the
dhm/studio_asides
branch
from
2318136
to
d49c82f
Compare
|
@doctoryes addr'd all comments except extraction of common code in tests. can I get a thumb? |
|
👍 |
dmitchell
added a commit
that referenced
this pull request
Dec 18, 2014
make asides render in studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces https://github.com/edx/edx-platform/pull/6277 based on master rather than the other branch.
@doctoryes i don't see a thumb from you on either PR