add find_fixme task #6173
Merged
add find_fixme task #6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| sh( | ||
| "{pythonpath_prefix} pylint --disable R,C,W,E --enable=W0511 " |
There was a problem hiding this comment.
should the enable switch be 'fixme' instead of W0511?
|
What can we do to add some testing on this change? |
| @@ -69,9 +69,9 @@ def test_failure_on_diffquality_pep8(self): | |||
|
|
|||
| # Underlying sh call must fail when it is running the pep8 diff-quality task | |||
| self._mock_paver_sh.side_effect = CustomShMock().fail_on_pep8 | |||
| with self.assertRaises(SystemExit): | |||
There was a problem hiding this comment.
@benpatterson I've added a test, but for some reason it seems to be causing these two other tests to fail locally (maybe on jenkins too). This change fixes them... but I'm not sure why my test causes the failure to begin with. Any ideas?
There was a problem hiding this comment.
Yeah, try pulling it into a separate file. That might clean it up.
clytwynec
force-pushed
the
clytwynec/add_find_fixme_method
branch
2 times, most recently
from
a33361c
to
175a066
Compare
|
@benpatterson Looks like moving the test to another file didn't actually fix it. :( |
clytwynec
force-pushed
the
clytwynec/add_find_fixme_method
branch
from
175a066
to
3ea27a3
Compare
clytwynec
force-pushed
the
clytwynec/add_find_fixme_method
branch
from
3ea27a3
to
7cb2665
Compare
|
@benpatterson I've removed the tests and addressed other comments. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes from https://github.com/edx/edx-platform/pull/6122, we will no longer be finding fixmes with
run_qualityorrun_pylint. This change adds a way of finding only fixmes. I've added it to the all-tests.sh script in the quality shard, so that jenkins builds will find the fixmes (writing them to their own log) without failing the builds.