Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOL-20 add content type filters instead of extension, fix css issues, ad... #6084

Closed

Conversation

dino-cikatic
Copy link
Contributor

...d filter text to pagination header

@martynjames this is a branch implementing SOL-20 fixes. It is pushed to solutions because I don't have permissions to push it to platform.

@openedx-webhooks
Copy link

Thanks for the pull request, @dino-cikatic! I've created OSPR-246 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ('this must be merged by XX date', and why that is)
  • partner information ('this is a course on edx.org')
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation and added yourself to the AUTHORS file. Please see the CONTRIBUTING file for more information.

@chrisndodge
Copy link
Contributor

Hi @dino-cikatic there are a few pep8 violations and a few failing JS unit tests (you can see them listed in the build report). Thx.

@martynjames
Copy link

Closing to keep feature work within solutions fork until ready to submit to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants