Clean up all modulestore testcases #6078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzoldak
force-pushed
the
zoldak/modulestore-test-refactor
branch
8 times, most recently
from
7a12f8d
to
c0833af
Compare
|
@benpatterson @muhammad-ammar could you please review? |
| @@ -66,7 +67,12 @@ def get_json(self, path, data=None, follow=False, **extra): | |||
| return self.get(path, data or {}, follow, HTTP_ACCEPT="application/json", **extra) | |||
|
|
|||
|
|
|||
| @override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE) | |||
There was a problem hiding this comment.
Review note: This will make sure that the studio tests use the lightest weight modulestore by default. The studio testcases rely on this CourseTestCase class rather than ModuleStoreTestCase directly.
jzoldak
force-pushed
the
zoldak/modulestore-test-refactor
branch
3 times, most recently
from
7d83887
to
ddb2858
Compare
|
@jzoldak as discussed, I 👍 the changes, with the idea that the tests being skipped now will be addressed in a subsequent PR. |
jzoldak
force-pushed
the
zoldak/modulestore-test-refactor
branch
from
ddb2858
to
4bb9ffe
Compare
added 2 commits
December 2, 2014 07:09
Move modulestore config for tests to an importable location Disable pylnt warning for lms imports in common tests Refactor all testcases that loaded all xml courses TE-610 TE-489
jzoldak
force-pushed
the
zoldak/modulestore-test-refactor
branch
from
4bb9ffe
to
121b313
Compare
jzoldak
pushed a commit
that referenced
this pull request
Dec 2, 2014
Clean up all modulestore testcases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpennington @ormsbee
I'm breaking the work of mocking out the modulestore into a couple pieces so it's not in a huge PR that touches a bazillion files.
This first PR is a cleanup of all unit testcases that need a modulestore but aren't actually testing the modulestore implementation. Let's get this in first. Next will be the PR that mocks out the modulestore.
Included in this PR:
An interesting aside is that PR #6061 that mocks out mongo is running unit tests in ~30 min. :)