Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spacing of RTL icon in discussion #5835

Merged
merged 1 commit into from
Nov 4, 2014
Merged

Fixed spacing of RTL icon in discussion #5835

merged 1 commit into from
Nov 4, 2014

Conversation

OmarIthawi
Copy link
Member

The search icon is misplaced in RTL platform:

English (OK)

discussion-en

Arabic (Before, not broken)

rtl-arabic-before

Arabic (After, fixed)

discussion-after

@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! I've created OSPR-183 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add information to the ticket which can help Product understand the context for the PR - supporting documentation, edx-code email threads, timeline information ('this must be merged by XX date', and why that is), partner information (this is for a course on edx.org, for example), etc.

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

@sarina
Copy link
Contributor

sarina commented Nov 4, 2014

LGTM

@frrrances can you take a quick look?

@frrrances
Copy link
Contributor

thanks @OmarIthawi! 👍

@sarina
Copy link
Contributor

sarina commented Nov 4, 2014

@frrrances when it's open source PR, you can feel free to go ahead and merge - if youre not comfortable doing so, though, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants