Jonahstanley/upgrade chrome version #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,10 @@ def create_component_instance(step, component_button_css, category, | |||
|
|
|||
| click_new_component_button(step, component_button_css) | |||
|
|
|||
| def animation_done(_driver): | |||
| return world.browser.evaluate_script("$('div.new-component').css('display')") == 'none' | |||
| world.wait_for(animation_done) | |||
There was a problem hiding this comment.
I'm getting acceptance test failures here:
Given I have created a Video component # cms/djangoapps/contentstore/features/common.py:208
Traceback (most recent call last):
File "/usr/local/Cellar/python/2.7.4/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/lettuce/core.py", line 143, in __call__
ret = self.function(self.step, *args, **kw)
File "/Users/db/dev/edx-platform/cms/djangoapps/contentstore/features/common.py", line 213, in i_created_a_video_component
has_multiple_templates=False
File "/Users/db/dev/edx-platform/cms/djangoapps/contentstore/features/component_settings_editor_helpers.py", line 18, in create_component_instance
world.wait_for(animation_done)
File "/Users/db/dev/edx-platform/common/djangoapps/terrain/ui_helpers.py", line 23, in wait_for
WebDriverWait(world.browser.driver, 5).until(func)
File "/usr/local/Cellar/python/2.7.4/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/selenium/webdriver/support/wait.py", line 71, in until
raise TimeoutException(message)
TimeoutException: Message: ''
There was a problem hiding this comment.
This should be fixed... I forgot that one click components do not have animations so I made a check for which component type we are creating
| @@ -12,12 +12,17 @@ def create_component_instance(step, component_button_css, category, | |||
| has_multiple_templates=True): | |||
|
|
|||
| click_new_component_button(step, component_button_css) | |||
| if category == 'problem' or category == 'html': | |||
There was a problem hiding this comment.
Nitpick: it's simpler and clearer to write if category in ('problem', 'html'):
|
Does that meant that the tests were working or just that you noticed those two issues? |
|
Just noticed the issues. I can retry the tests now, if you think they will work. |
|
I think they will. I am pretty sure I fixed those two broken tests you were seeing before |
|
More errors, but they don't seem related to the lines of code that you changed, so I don't know what to make of them. :( |
|
Never mind -- must have been a fluke. I re-ran the tests, and they all passed. |
|
👍 |
|
Runs for me on the old version of Chrome as well. 👍 |
JonahStanley
pushed a commit
that referenced
this pull request
Jul 31, 2013
Jonahstanley/upgrade chrome version
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Feature/fix backbone js
yokose-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Dec 1, 2015
kawaguchi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Dec 1, 2015
…age-user-certificate-feature Add manage user certificate feature (openedx#516)
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
farhaanbukhsh
pushed a commit
that referenced
this pull request
Mar 20, 2023
…language_nutmeg fix: use language specified in SiteConfiguration [BB-6930]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested reviewers: @singingwolfboy @jzoldak
The following features had issues with chrome/chrome driver versions
lms/djangoapps/courseware/features/homepage.feature
cms/djangoapps/contentstore/features/advanced-settings.feature
cms/djangoapps/contentstore/features/html-editor.feature
cms/djangoapps/contentstore/features/problem-editor.feature
cms/djangoapps/contentstore/features/section.feature
cms/djangoapps/contentstore/features/subsection.feature
cms/djangoapps/contentstore/features/upload.feature
cms/djangoapps/contentstore/features/video-editor.feature
cms/djangoapps/contentstore/features/video.feature
In order to fix these, the following things were changed:
These changes were tested in chrome version 28.0.1500.71 and chromedriver 2.1.210398
testing.md was updated accordingly. It is also important to note that this version of chromedriver is compatible with versions 27-30 meaning that it won't work with chrome 26 (what a lot of people might be running) explaining why both need to be updated at once.
All changes that were made should be backwards compatible due to the nature of the changes (since mostly only verification steps were added). world.wait_for is an implicit wait so these tests shouldn't take any longer to run.