Fixes git export to support repositories with dots in their name and cleans export repo #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that additional exports of the content are the same the first.
|
Thank you for the clean code and 100% test coverage. Looks good and makes sense. |
sarina
added a commit
that referenced
this pull request
Sep 9, 2014
Fixes git export to support repositories with dots in their name and cleans export repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit:
Currently the export to git will cut off the "extension" of the repository name and export the courseware to the wrong directory. This corrects this behavior and adds a regression test to validate the fix.
Second commit:
If something is deleted in the remote repo for a course and it is exported from Studio the deleted items get added back in. This corrects that behavior to clean the repo before exporting the course.