Conditionalize external_login_or_signup shib behavior on existence of apache shib vars #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,7 +148,7 @@ def external_login_or_signup(request, | |||
| log.info(u"External_Auth login_or_signup for %s : %s : %s : %s", external_domain, external_id, email, fullname) | |||
| internal_user = eamap.user | |||
| if internal_user is None: | |||
| if settings.MITX_FEATURES.get('AUTH_USE_SHIB'): | |||
| if settings.MITX_FEATURES.get('AUTH_USE_SHIB') and 'shib:' in external_domain[0:5]: | |||
|
There are several more places that need to check for shibboleth. These changes are included in PR 511. |
|
Closing, as this is obsoleted by #511 |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Quick workaround on syllabus_present that broke staging
hachiyanagi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Dec 4, 2015
…lete-course-with-assets Add purge flag in delete_course openedx#411
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
…lment_api_performance Performance fix for enrollment roster api.
yoann-mroz
pushed a commit
to weuplearning/edx-platform
that referenced
this pull request
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brianhw @cpennington
As discussed over email