Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for vagrant up #453

Merged
merged 1 commit into from
Jul 22, 2013
Merged

Fixes for vagrant up #453

merged 1 commit into from
Jul 22, 2013

Conversation

singingwolfboy
Copy link
Contributor

Rebased off #398. @yarko, since there were conflicts, can you please review and make sure this looks good?

vagrant:
  - check actual IP;
  - only init machine first time, just as native installations;
  - add .bash_profile to permissions fixup;
  - cleanup excessive newlines in making .bash_profile;

README:
  - include admin & debugging use;
  - info about re-initializing VM & manually running create-dev-env.sh;
  - add django admin & debug_toolbar setting info

Conflicts:
	AUTHORS
	scripts/vagrant-provisioning.sh
@yarko
Copy link
Contributor

yarko commented Jul 22, 2013

@siningwolfboy - Read thru, seems fine. Fetched this pull #453, and did a clean, new machine bringup.
I've done no more than cursory testing (this doesn't touch the CMS code), and looks good to me.

singingwolfboy added a commit that referenced this pull request Jul 22, 2013
@singingwolfboy singingwolfboy merged commit f780369 into master Jul 22, 2013
@singingwolfboy singingwolfboy deleted the yarko/vagrant-up-fix branch July 22, 2013 16:29
Kelketek referenced this pull request in open-craft/edx-platform Jul 15, 2015
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
* stv/xss/learner-name:
  Properly escaping fullname
  Properly escape the name
  Escape full name
xavierchan pushed a commit to xavierchan/edx-platform-1 that referenced this pull request May 31, 2019
feat(program): hide the program navbar bar when user didn't enroll pr…
andrey-canon added a commit to eduNEXT/edx-platform that referenced this pull request Jan 19, 2021
ju/ednx/Ju-10 Comment migration log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants