Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyla/templates #404

Merged
merged 5 commits into from
Jul 18, 2013
Merged

Lyla/templates #404

merged 5 commits into from
Jul 18, 2013

Conversation

Lyla-Fischer
Copy link

@cpennington @dmitchell can you check out these changes/additions to the studio templates?

</p>
<p>Which animal shown below is a kitten?</p>
<imageresponse>
<imageinput src="https://studio.edx.org/c4x/edX/DemoX/asset/Dog-and-Cat.jpg" width="640" height="400" rectangle="(385,98)-(600,337)"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, this link to an outside course's assets is going to be a problem to manage long term, i.e. what happens if that course gets deleted. I don't know if there's a workaround right now and probably part of a bigger discussion about templates that have dependencies (e.g. links, embedded images, etc.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I have a ticket out to put these images on amazon s3, but I figured that I could update those next week or something after the images were uploaded. As it stands, I wanted to try to get this into the release candidate so that people would have a reference for drag-and-drop other than the rumors and word-of-mouth that the question type exists.

@Lyla-Fischer
Copy link
Author

Great! The new template now doesn't have defaults, and I will let the other patch take care of defaults for imageresponse. Can I get an amen?

@dmitchell
Copy link
Contributor

Cale just merged the template refactoring; so, please remove the children
field too.

@dmitchell
Copy link
Contributor

Otherwise great

On Tue, Jul 16, 2013 at 5:36 PM, Don-edX Mitchell [email protected] wrote:

Cale just merged the template refactoring; so, please remove the children
field too.

@Lyla-Fischer
Copy link
Author

@cpennington can you confirm or deny the good-ness of this pull request?

@cpennington
Copy link
Contributor

👍, but can you post a link to the JIRA story that covers moving the image to S3 (and create said story if it doesn't exist?) I don't want that to get lost.

@Lyla-Fischer
Copy link
Author

Lyla-Fischer pushed a commit that referenced this pull request Jul 18, 2013
Adding a template for drag-and-drop.
@Lyla-Fischer Lyla-Fischer merged commit ee01798 into master Jul 18, 2013
@Lyla-Fischer Lyla-Fischer deleted the lyla/templates branch July 18, 2013 14:03
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
…ustomresponse

fix customresponse be consistent with "no answer entered" behavior
yoann-mroz pushed a commit to weuplearning/edx-platform that referenced this pull request Nov 30, 2020
MoisesGSalas pushed a commit to eduNEXT/edx-platform that referenced this pull request Jan 12, 2022
…4781-add-custom-html-templates-in-studio

Revert "Pedrovgp/se4781 add custom html templates in studio"
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
As part of making the new courseware experience the
default for staff, the LMS /jump_to/ links that are
exposed by the Course Blocks API via the `lms_web_url`
field will soon direct users to whichever experience
is active to them (instead of always directing to
the legacy experience & relying on the learner
redirect).

Because of this, the MFE can no longer rely on
`lms_web_url` to land a staff user to the legacy
experience. However, the aformentioned change
will also introduce a `legacy_web_url` field
to the API, which we *can* use for this purpose.

TNL-7796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants