-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lyla/templates #404
Lyla/templates #404
Conversation
</p> | ||
<p>Which animal shown below is a kitten?</p> | ||
<imageresponse> | ||
<imageinput src="https://studio.edx.org/c4x/edX/DemoX/asset/Dog-and-Cat.jpg" width="640" height="400" rectangle="(385,98)-(600,337)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, this link to an outside course's assets is going to be a problem to manage long term, i.e. what happens if that course gets deleted. I don't know if there's a workaround right now and probably part of a bigger discussion about templates that have dependencies (e.g. links, embedded images, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. I have a ticket out to put these images on amazon s3, but I figured that I could update those next week or something after the images were uploaded. As it stands, I wanted to try to get this into the release candidate so that people would have a reference for drag-and-drop other than the rumors and word-of-mouth that the question type exists.
Great! The new template now doesn't have defaults, and I will let the other patch take care of defaults for imageresponse. Can I get an amen? |
Cale just merged the template refactoring; so, please remove the children |
Otherwise great On Tue, Jul 16, 2013 at 5:36 PM, Don-edX Mitchell [email protected] wrote:
|
@cpennington can you confirm or deny the good-ness of this pull request? |
👍, but can you post a link to the JIRA story that covers moving the image to S3 (and create said story if it doesn't exist?) I don't want that to get lost. |
Adding a template for drag-and-drop.
…ustomresponse fix customresponse be consistent with "no answer entered" behavior
…4781-add-custom-html-templates-in-studio Revert "Pedrovgp/se4781 add custom html templates in studio"
As part of making the new courseware experience the default for staff, the LMS /jump_to/ links that are exposed by the Course Blocks API via the `lms_web_url` field will soon direct users to whichever experience is active to them (instead of always directing to the legacy experience & relying on the learner redirect). Because of this, the MFE can no longer rely on `lms_web_url` to land a staff user to the legacy experience. However, the aformentioned change will also introduce a `legacy_web_url` field to the API, which we *can* use for this purpose. TNL-7796
@cpennington @dmitchell can you check out these changes/additions to the studio templates?