Validate date/time settings when typed in directly.

[peter-fogg]

The changeTime event isn't fired when the user types in the field, but
only when clicking on the time in the dropdown. I'd consider this a
timepicker bug, but for now we can just listen to the user typing in
the field and update the value (and thus validate) like we do with
other field types.

[peter-fogg]

Presumably nobody's going to get to this until next week, but @cahrens or @singingwolfboy could review.

[chrisndodge]

Looks like a trivial change so it'd be good IMO to get this completed today before the RC is made. Can one other JS person at the company look at it? Maybe @talbs?

[talbs]

Thanks for the heads up, @chrisndodge. I took a spin through the branch locally and things seemed to work just as they currently are on stage. @peter-fogg, is there supposed to be any visible functionality change?

[peter-fogg]

@talbs Not a very big one, but it's there -- try setting the course start date to 01:00, and the end date to 02:00 of the same day. This should validate. Then directly type 00:00 into the end date time, and you should see no validation error. This PR causes validation when you type, so setting to midnight will end up showing the error.

[cahrens]

This looks fine to me, but run it quickly by @dmitchell. I think he originally was listening to more events, but backed off because methods were getting called too frequently?

I checked out the branch and tested it. Assuming @dmitchell is good, I am 👍

[dmitchell]

👍