Check YouTube for Bok-Choy #3948
Conversation
|
👍 |
| except requests.exceptions.ConnectionError: | ||
| return False | ||
|
|
||
| if response.status_code != 200: |
There was a problem hiding this comment.
Can we check if status code is less that 400 status code?
if response.status_code < 400:
...4xx and 5xx are error codes. But 204 code is successful.
There was a problem hiding this comment.
hm...Actually I am not sure about this.
@auraz What do you think?
There was a problem hiding this comment.
3xx are redirects, and if google does not do redirects, we should use at least < 300.
Regarding 2xx, 2xx are success so we should support them
There was a problem hiding this comment.
Google does not redirects but the ISPs who are blocking YouTube can redirect. Here in my country YouTube is blocked and when you try to access, it will redirect to some other page by the ISP.
There was a problem hiding this comment.
One thing i forgot to mention is that in the above case request.get gives me 200
|
👍 |
| from bok_choy.promise import EmptyPromise | ||
|
|
||
|
|
||
| def youtube_availability(): |
There was a problem hiding this comment.
please name this "is_youtube_available"
|
👍 |
Check YouTube for Bok-Choy
No description provided.