Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unpin mistune, docutils, and sphinxcontrib-openapi #31580

Closed
wants to merge 1 commit into from

Conversation

timmc-edx
Copy link
Contributor

This allows dropping the unmaintained m2r package.

This allows dropping the unmaintained m2r package.
@timmc-edx
Copy link
Contributor Author

@UsamaSadiq I saw that the relevant openai issue had been closed, so I tried unpinning that and a few related dependencies to see what would happen. If the docs build passed, does that mean we're good to go? Or was the error you observed here sphinx-contrib/openapi#129 (comment) seen in some other context?

@UsamaSadiq
Copy link
Member

Hi @timmc-edx, arbi-bom has created PR (#31574) to make this change already. That PR will be merged & deployed today so this PR won't be needed any more.
Please let us know if we'd need to backport this change to Olive as well.

@timmc-edx
Copy link
Contributor Author

Ah, wonderful! Closing this one out.

And yes, I think backporting to Olive would be a good idea -- the fewer constraints we have in general, the easier it is to get security upgrades to dependencies.

@timmc-edx timmc-edx closed this Jan 18, 2023
@timmc-edx timmc-edx deleted the timmc/m2r branch January 18, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants