Felix/hinter2 #303
Felix/hinter2 #303
Conversation
ghost
assigned 
| default='False') | ||
| debug = String(help='String "True"/"False" - allows multiple voting', scope=Scope.content, | ||
| default='False') | ||
| # hints[answer] = {str(pk): [hint_text, #votes]} |
There was a problem hiding this comment.
Why is this commented out? If it's supposed to be a helpful comment, I think you want to add some actual text to explain what this means.
There was a problem hiding this comment.
Yeah, sorry. That's how I document dictionary-like data structures. It means "hints is a dictionary that takes answer keys. Each value is itself a dictionary, accepting pk keys as strings, and returning [hint text, #votes] pairs as values."
I'll add an explanation to the comment.
|
Those are my current comments. I don't want to force you into a redesign too soon, but long term planning, I think this would work with more object-oriented design in this. You're doing a lot of indexing to pull out information out of these structured lists, and it would make your code a lot easier to read if you created small struct-like classes to hold this information. |
Conflicts: common/static/coffee/src/logger.coffee
Added moderation feature - you can now choose to hold all hints for moderator approval before showing.
… the crowdsource hinter module. (Old tests no longer cover all the code, now that moderation has been added.)
…ier to read. Fixed database non-initialization bug in crowdsource hinter module.
…nsitive. Still very hacky.
Fixed some bugs in the tests for crowdsourced hinter.
Hinter now displays vote count after voting. Began testing templates.
Chiseled a little at writing template tests.
Began enforcing one-vote-per-person. This can be disabled with debug="True" in the <crowdsource_hinter> tag. Started tests of the hint manager.
…ents - this lets us test the hint manager.
…anager. Expanded tests of hint_manager. Enabled the hint_manager by default in development environments.
Expanded test coverage a little.
…dded some HTML formatting to same.
Fixed various commenting things. Removed an unused function in the crowdsourced module coffeescript. Improved commenting in hint_manager. Fixed pep and pylint violations.
|
👍 I think this is ready to be merged. |
…nsitional_ids mattdrayer/api-migrate_transitional_ids: Cleaned up two additional table...
…generation-fix
Experimental release of crowdsourced hinting module. Expected to be used in 2.01x starting Tuesday, July 2.
@rocha
@pmitros