Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new django-admin command to dump out a course structure document. ... #294

Merged
merged 1 commit into from
Jul 19, 2013

Conversation

chrisndodge
Copy link
Contributor

...This is response to an emergency request from Harvard researchers.

NOTE: This was written for Jim Waldo as he needed a mapping table from the i4x://.... identifiers to some contextual information (e.g. where is that object in relation to the whole tree, what is the metadata, etc.). Jim Waldo signed off on the utility of it so I'd like to get this on master so that it can be part of the weekly analytics dump that is provided for Harvard.

NOTE: There's uncertainty as to whether this dump really fulfills the requirements or not. Keeping PR open for discussion.

@ghost ghost assigned cahrens Jun 27, 2013
in a JSON format. This can be used for analytics.'''

def handle(self, *args, **options):
if len(args) < 1 and len(args) > 3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might have meant this?
if len(args) < 2 or len(args) > 3:

@ghost ghost assigned jtauber Jul 9, 2013
@cpennington
Copy link
Contributor

@chrisndodge is there any discussion happening on this?

@chrisndodge
Copy link
Contributor Author

@cpennington let me ping some of the analytics people (and Jim) and see if they want it merged or not

@chrisndodge
Copy link
Contributor Author

Rebased to pick up latest code

@chrisndodge
Copy link
Contributor Author

@jtauber can you review. JZ went through it and found one thing that I fixed for him. I think the comment got lost on the rebase?!?

@cpennington
Copy link
Contributor

The comment is still there (it's mentioned as being made about an outdated diff)

in a JSON format. This can be used for analytics.'''

def handle(self, *args, **options):
if len(args) < 2 and len(args) > 3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len(args) can't be both less than 2 and greater than 3. Did you mean len(args) < 2 or len(args) > 3 or 2 < len(args) < 3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks you meant the former.

@cpennington
Copy link
Contributor

Can you squash these into one commit? (you can use git fixup from https://edx-wiki.atlassian.net/wiki/display/ENG/Helpful+Git+Pointers)

…t. This is response to an emergency request from Harvard researchers.
@chrisndodge
Copy link
Contributor Author

@cpennington ok squashed

@chrisndodge
Copy link
Contributor Author

@cpennington can we finalize this? Ironically there's a request on the OS forums for this feature...

@cpennington
Copy link
Contributor

👍

chrisndodge pushed a commit that referenced this pull request Jul 19, 2013
…ture

add a new django-admin command to dump out a course structure document. ...
@chrisndodge chrisndodge merged commit d78af5c into master Jul 19, 2013
@chrisndodge chrisndodge deleted the feature/cdodge/add-dump-course-structure branch August 8, 2013 18:38
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
reading WIKI_ENABLED from env.json
e-kolpakov referenced this pull request in open-craft/edx-platform Nov 3, 2014
…age-to-overview

ziafazal/api-add-course-image-to-overview: added course_image_url to course overview api
kawaguchi-ks added a commit to nttks/edx-platform that referenced this pull request Oct 6, 2015
diegomillan referenced this pull request in eduNEXT/edx-platform Sep 14, 2016
…test

Cherry pick skip flaky youtube test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants