-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new django-admin command to dump out a course structure document. ... #294
Conversation
in a JSON format. This can be used for analytics.''' | ||
|
||
def handle(self, *args, **options): | ||
if len(args) < 1 and len(args) > 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might have meant this?
if len(args) < 2 or len(args) > 3:
@chrisndodge is there any discussion happening on this? |
@cpennington let me ping some of the analytics people (and Jim) and see if they want it merged or not |
Rebased to pick up latest code |
@jtauber can you review. JZ went through it and found one thing that I fixed for him. I think the comment got lost on the rebase?!? |
The comment is still there (it's mentioned as being made about an outdated diff) |
in a JSON format. This can be used for analytics.''' | ||
|
||
def handle(self, *args, **options): | ||
if len(args) < 2 and len(args) > 3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
len(args)
can't be both less than 2 and greater than 3. Did you mean len(args) < 2 or len(args) > 3
or 2 < len(args) < 3
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks you meant the former.
Can you squash these into one commit? (you can use |
…t. This is response to an emergency request from Harvard researchers.
@cpennington ok squashed |
@cpennington can we finalize this? Ironically there's a request on the OS forums for this feature... |
👍 |
…ture add a new django-admin command to dump out a course structure document. ...
reading WIKI_ENABLED from env.json
…age-to-overview ziafazal/api-add-course-image-to-overview: added course_image_url to course overview api
Merge tag 'release-2015-09-02'
…test Cherry pick skip flaky youtube test
...This is response to an emergency request from Harvard researchers.
NOTE: This was written for Jim Waldo as he needed a mapping table from the i4x://.... identifiers to some contextual information (e.g. where is that object in relation to the whole tree, what is the metadata, etc.). Jim Waldo signed off on the utility of it so I'd like to get this on master so that it can be part of the weekly analytics dump that is provided for Harvard.
NOTE: There's uncertainty as to whether this dump really fulfills the requirements or not. Keeping PR open for discussion.