Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HACKED TOGETHER time limit for DB class midterm #2471

Merged
merged 1 commit into from
Feb 5, 2014

Conversation

jbau
Copy link

@jbau jbau commented Feb 5, 2014

Note this is to edx-west/rc, not master:

@jaericson
Please review thoroughly and test on your dev environment thoroughly. If I don't get a thumbs up from you before say noonish tomorrow, then I won't release.

@nparlante can you be the second reviewer on this (also before noon tomorrow)? I'll explain in email.

@jbau
Copy link
Author

jbau commented Feb 5, 2014

This is a hacked capa timed exam. It only works within DB class parameters (i.e. 1 submission allowed). Timer starts when the exam is rendered to the student ("get_problem_html()")

@jaericson
Copy link

I just tested it, and it looks great to me! Thank you so much for doing all of this under an impossible timeframe! Not sure what the "tests failed" below means.

The only item I'd change, since we're patching this now exclusively for the midterm (and later final) exams in the DB class, is the wording in the problem.html file to this:

At (time), you started this exam.
By (time), you must manually click the "Final Submit" button at the bottom of the page!

Here's what I tested:

  • leaving the problem doesn't reset the starting or ending time
  • one can successfully submit before the timer has elapsed, up to and including the 1-minute grace period
  • one is told that the problem state has changed and must reload the page if they click the submit button after the 1-minute grade period
  • progress reported correctly when able to submit; progress is 0 when trying to submit after the deadline
  • when the exam is due before the start time plus allowed_minutes, the exam due time is displayed, not the start time plus allowed_minutes

Thanks so much, Jason!

jbau added a commit that referenced this pull request Feb 5, 2014
HACKED TOGETHER time limit for DB class midterm
@jbau jbau merged commit 25524f5 into edx-west/rc-20140206 Feb 5, 2014
@jbau jbau deleted the jbau/timed-capa branch February 6, 2014 03:35
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Mar 23, 2018
* Add ORA2 video upload option openedx#2375 (openedx#2417)

* Modified courseware page look and feel openedx#2377 (openedx#2409)

* Modified about page openedx#2379 (openedx#2413)

* Fix biz bugs. openedx#2404 (openedx#2406)

* Fix display width of popup. (openedx#2384)

(cherry picked from commit a43c935a575d15fcf629f0edeb81446c778cda95)

* Validate duplicate url-code.

* Fix bug, when course not found.

* Fix order of course as CourseOverview.

* Remove additional-info count from contract grid. openedx#2419 (openedx#2437)

* Fix order global course. openedx#2420 (openedx#2421)

* Add additional info register. openedx#2419 (openedx#2433)

* fix survey csv character encode problem openedx#2380 (openedx#2434)

* Fix bokchoy for LoginCodeEnabledBizSurveyTest. (openedx#2457)

* Fix register students confirm message. (openedx#2461)

* Add command to check playback_log. openedx#2438 (openedx#2445)

* Fix courseware page lookandfeel (openedx#2446, openedx#2439, openedx#2452, openedx#2453)

* Fix box-shadow of sequence-nav-button. openedx#2453 (openedx#2467)

* Fix bugs. openedx#2462 openedx#2463 (openedx#2464)

* Fix password message in register students page.

* Fix glass pane of processing when register additional item.

* Fix display width of popup. (openedx#2466)

* Fix min-width of sequence-nav. openedx#2468 (openedx#2469)

* Fix isRegistered javascript in about page openedx#2470 (openedx#2471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants