Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up strings in the ErrorModule #2432

Merged
merged 1 commit into from
Feb 3, 2014
Merged

Clean up strings in the ErrorModule #2432

merged 1 commit into from
Feb 3, 2014

Conversation

dianakhuang
Copy link
Contributor

  1. Refactor code slightly so that we're only setting a default error_msg at the very end if we don't already have one.
  2. Remove a confusing and unused display_name that has untranslated string

@nedbat @sarina ?

@sarina
Copy link
Contributor

sarina commented Feb 3, 2014

👍

1 similar comment
@nedbat
Copy link
Contributor

nedbat commented Feb 3, 2014

👍

dianakhuang added a commit that referenced this pull request Feb 3, 2014
@dianakhuang
Merge pull request #2432 from edx/diana/error-module-i18n
0ee9a72 
Clean up strings in the ErrorModule
@dianakhuang dianakhuang merged commit 0ee9a72 into master Feb 3, 2014
@dianakhuang dianakhuang deleted the diana/error-module-i18n branch February 3, 2014 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dianakhuang @sarina @nedbat