Pass component display name to Mako template #2401
Conversation
|
👍 Looks great. As we just discussed, I think you need to handle the "Unnamed Component" logic too. |
| Given I am in Studio editing a new unit | ||
| When I add a "Text" "HTML" component | ||
| Then I see the display name is "Text" | ||
| When I change the display name to "I'm the Cuddliest!" |
There was a problem hiding this comment.
problem-editor.py has methods for setting the display name and verifying the display name. Could you reconcile these methods and put them in a shared location?
|
If display_name is None, perhaps use the category like I did for duplicate (also in item.py)? I don't think it is possible for the category to be None. |
|
PR now includes visual styling adjustments to component header. |
|
👍 This looks really nice with the new design. |
|
👍 Do we need anyone to review Marco's changes? Visually it looks good to me, though when your unit is Public it feels like there is a lot of empty white space at the top of the component (although I think this was the case before as well). |
|
@cahrens - Agreed with the empty white space at the top of the component looking a bit odd, but as this is still the case prior to my changes here, I opted to leave it for now. Hopeful the new container story will help with some of the padding oddness of this page. |
Pass component display name to Mako template
No description provided.