Fix Facebook and Google social auth buttons. #20282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facebook emailed that edX doesn't comply with Platform Policy 8.3, also fixed Google button according to their policy. PROD-174
|
jenkins run ironwood/js |
|
jenkins run all |
|
@nedbat I have created this PR as per @nasthagiri's request https://github.com/edx/edx-platform/pull/20206#issuecomment-485252893. CC: @fysheets |
|
Your PR has finished running tests. The following contexts failed:
|
|
jenkins run ironwood/bokchoy |
|
jenkins run bokchoy |
|
We may be able to merge this PR even with the failing bokchoy tests - since they are unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on https://github.com/edx/edx-platform/pull/20206.
Description:
Facebook emailed that edX doesn't comply with Platform Policy 8.3, also fixed
Google and Microsoft buttons according to their policy.
Note: Along with these changes, one has to upload the SVG logo files provided by the third party auth provider into their respective
OAuth2ProviderConfigobjects Icon Image field instead of the Icon class.PROD-174