Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run make upgrade #19724

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Run make upgrade #19724

merged 1 commit into from
Feb 1, 2019

Conversation

crice100
Copy link
Contributor

@crice100 crice100 commented Feb 1, 2019

Testing python unit tests without the firebase changes from https://github.com/edx/edx-platform/pull/19682

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@crice100
Copy link
Contributor Author

crice100 commented Feb 1, 2019

@edx/incr-reviewers This isn't a crucial PR, but merging it might help shrink the diffs for the other INCR tickets with (possibly) flaky python test results

@jmbowman
Copy link
Contributor

jmbowman commented Feb 1, 2019

Did you specifically avoid upgrading pytest? A few PRs that recently upgraded it to 4.2.0 have been having issues, but I don't see anything in your changes that pins it either. cc @michaelyoungstrom

@jmbowman
Copy link
Contributor

jmbowman commented Feb 1, 2019

Aha, the just-released version of pytest-django prevents the upgrade: pytest-dev/pytest#4704. That wasn't there when the other PRs ran make upgrade.

@crice100 crice100 merged commit 545b93f into master Feb 1, 2019
@crice100 crice100 deleted the crice/upgrade branch February 1, 2019 16:55
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Monday, February 04, 2019.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmbowman jmbowman jmbowman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crice100 @edx-status-bot @jmbowman @edx-pipeline-bot