Fix reporting drop down menu on data-download instructor dashboard. #18786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins run python |
|
Your PR has finished running tests. There were no failures. |
awaisdar001
reviewed
Aug 15, 2018
| @@ -1541,6 +1541,7 @@ | |||
| background: white; | |||
| padding: 5px; | |||
| box-shadow: 0 3px 6px rgba(0, 0, 0, 0.16), 0 3px 6px rgba(0, 0, 0, 0.23); | |||
| z-index: 2; | |||
There was a problem hiding this comment.
Why z-index 2? Is it relevant to other z-index?
There was a problem hiding this comment.
By default it has the z-index: auto property and when we set z-index:1 it faded out something like this.
On this index, it working fine.
awaisdar001
approved these changes
Aug 15, 2018
asadazam93
approved these changes
Aug 16, 2018
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, August 17, 2018. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
This was referenced Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDUCATOR-3327
Description:
This PR fixes the display of Section Problem Reporting Drop Down menu that is hidden behind the report list
How to Test?
Prod Edge
https://edge.edx.org/courses/course-v1:UQx+UQACADEMICINTEGRITY+2018/instructor#view-data_download
Sandbox
https://menu.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/instructor#view-data_download
Screenshot
Before Fix
After Fix
Reviewers
If you've been tagged for review, please check your corresponding box once you've given the 👍.
Post-review