Certificate messages must be dependent on active web configurations #18770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsan-ul-haq
approved these changes
Aug 15, 2018
uzairr
force-pushed
the
LEARNER-3325/cert-generation-message
branch
from
7c5af12
to
689d194
Compare
|
jenkins run quality |
Progress page is showing certificate messages for those courses in which certificates are not offered.To avoid it,a check is added on the existence of active course configuration so that it should be displayed only for courses offering certificates. LEARNER-3325
uzairr
force-pushed
the
LEARNER-3325/cert-generation-message
branch
from
689d194
to
a1a9e8e
Compare
waheedahmed
approved these changes
Aug 16, 2018
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, August 17, 2018. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEARNER-3325
Description
Progress page is showing certificate messages for those courses in which certificates are not offered. To avoid it,a check is added on the existence of active course configuration so that it should be displayed only for courses offering certificates.