Fixes for courseware anonymous access. #18344

symbolist · 2018-06-08T09:46:24Z

https://github.com/edx/edx-platform/pull/16315 added the ability to allow anonymous access to courseware. This PR makes small adjustments to the functionality:

The section tabs are no longer disabled. It was already possible to switch tabs with the arrows so no point in disabling them.
The front-end no longer tries to save the tab the learner is on or to fetch completion status of the unit when switching between units since those are only applicable to logged in users and cause a "Please login" message to pop up.

Note that currently only HTML blocks work correctly with anonymous access.

JIRA tickets: OSPR-2462

Screenshots: N/A

Merge deadline: None

Sandbox: https://pr18344.sandbox.opencraft.hosting/courses/course-v1:edX+DemoX+Demo_Course/courseware/interactive_demonstrations/

Reviewers

@xitij2000
edX reviewer[s] TBD

openedx-webhooks · 2018-06-08T09:46:32Z

Thanks for the pull request, @symbolist! I've created OSPR-2462 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

mduboseedx · 2018-06-08T16:21:14Z

@symbolist Thanks for the PR. Feel free to ping me once this is ready. Just so you know, we've had some issues with the quality so it may not pass at moment despite there not be an issue with quality.

Could you also add a Description once this is ready to be reviewed? Thanks!

symbolist · 2018-06-08T16:27:24Z

@mduboseedx I just added details to the description. Thanks for the note about the quality check! And I'll update you when this is ready to be reviewed.

e0d · 2018-06-11T17:34:30Z

@mulby @caesar2164 also noticed this in flight PR.

symbolist · 2018-06-13T17:04:30Z

@xitij2000 There is quality issue but besides that this is ready for review.

symbolist · 2018-06-13T17:56:53Z

jenkins run a11y

xitij2000

👍

I tested this: tested that navigation works when using the waffle flag
I read through the code
~~I checked for accessibility issues~~
~~Includes documentation~~

mduboseedx · 2018-06-14T20:11:09Z

@edx/learner @ormsbee This is related #16315 and #18134 about anonymous access to the courseware. Could this be given a review?

symbolist · 2018-06-15T17:04:36Z

@mduboseedx Thanks! I have also added a link to a sandbox for testing purposes.

symbolist · 2018-07-02T12:13:00Z

Hi @mduboseedx, is there an estimate for when this can get reviewed?

Also a heads up that OpenCraft is planning to work on some of the ideas discussed in https://github.com/edx/edx-platform/pull/18134 and will be submitting them for upstreaming.

mduboseedx · 2018-07-03T17:30:37Z

@edx/learner @rock345 Do you know when this might be reviewed?

fyi for @ormsbee

ormsbee

One nitpick about the line length, but otherwise, it looks fine to me. @edx/learner: is my review enough or do you folks feel that you need to look this over as well?

@symbolist, @xitij2000: Thank you for your patience in this.

ormsbee · 2018-07-19T02:07:39Z

lms/templates/seq_module.html

@@ -1,7 +1,7 @@
 <%page expression_filter="h"/>
 <%! from django.utils.translation import ugettext as _ %>

-<div id="sequence_${element_id}" class="sequence" data-id="${item_id}" data-position="${position}" data-ajax-url="${ajax_url}" data-next-url="${next_url}" data-prev-url="${prev_url}">
+<div id="sequence_${element_id}" class="sequence" data-id="${item_id}" data-position="${position}" data-ajax-url="${ajax_url}" data-next-url="${next_url}" data-prev-url="${prev_url}" data-save-position="${'true' if save_position else 'false'}" data-show-completion="${'true' if show_completion else 'false'}">


Nit: Please put a line break or two in here so we don't have a 300 column line.

edx-status-bot · 2018-07-20T10:05:57Z

Your PR has finished running tests. There were no failures.

symbolist · 2018-07-20T12:44:17Z

@ormsbee Thanks for the review! I have split the attributes across multiple lines as you suggested.
I have also done a rebase.

@mduboseedx FYI

pomegranited · 2018-08-14T06:40:23Z

@mduboseedx Could you check with the Learner team to see if @ormsbee 's approval here is enough to merge this? Should be squashed and merged if all is ok.

staubina · 2018-08-15T13:24:35Z

@ormsbee I believe your review is enough here.

pomegranited · 2018-08-16T00:20:48Z

Beautiful, thank you @staubina and @ormsbee ! @xitij2000 Could you please merge, since you have access to do so? CC @symbolist

xitij2000 · 2018-08-16T07:28:41Z

@pomegranited I don't have merge access here. I think only @bradenmacdonald does.

pomegranited · 2018-08-16T07:35:42Z

Ah ok thanks @xitij2000 . @ormsbee maybe, could you merge here if you're happy with this PR? CC @mduboseedx

openedx-webhooks · 2018-08-16T12:44:03Z

@symbolist 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

symbolist · 2018-08-16T13:22:27Z

Thanks @mduboseedx!

edx-pipeline-bot · 2018-08-16T15:41:47Z

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, August 17, 2018.

edx-pipeline-bot · 2018-08-17T15:26:19Z

EdX Release Notice: This PR has been deployed to the production environment.

micahl98 · 2019-02-28T17:20:57Z

I need to test this anonymous course access but cannot understand how exactly to set the waffle flag... it does appear to be in the latest openedx build, any guidance welcome!

pomegranited · 2019-03-01T00:49:44Z

Hi @micahl98, thanks for reaching out 😄 There's a DOCS PR to be completed and we're prepping a blog post about this now, but am happy to share more details about how to use this feature here.

Because this is a brand new feature, there's currently a two-step process to enable it for each course. This may change in the future as demand increases and further optimizations are developed.

To use this feature on your course:

Ask your site administrator to use Django Admin to enable the seo.enable_anonymous_courseware_access Waffle Flag for this feature. There are two choices here:
- Create a normal Waffle flag to enable this flag for all courses, setting the user restrictions as desired (see waffle docs for details):
- Create a Waffle flag course override with your course ID to enable this flag for specific courses.
View your course in Studio, and navigate to the Advanced Settings page. Locate the Course Visibility For Unenrolled Learners setting shown below:

By default, this is set to "private", which ensures that only enrolled learners can access your course content.
If you change this to "public_outline", then only your course outline will be visible to everyone.
If you change this to "public", then all of your course content will be visible to anyone.
If you want your course to be crawled by Google, you should also ensure that your course's About page is visible, and that it is shown in the course catalog. Without these settings, only people with a link to your course outline or specific content blocks will be able to find your course.

Locate the Advanced Settings > Course Visibility in Catalog setting, and ensure it is set to "both" as shown below:

robrap · 2019-03-01T15:02:07Z

@pomegranited: Would it cause a problem if you were to enable seo.enable_anonymous_courseware_access, but not take the additional steps? The reason I ask is that if it doesn't cause any issues, one could in theory just turn on the waffle flag seo.enable_anonymous_courseware_access, and not override course-by-course. If there is a reason you cannot do this, you may want to mention it in your docs. Thanks.

ormsbee · 2019-03-01T15:58:16Z

@robrap: I believe that's actually because we (edX) asked that it be restricted more tightly so that it could be rolled out on a course-by-course basis. This is a powerful feature that will likely see enthusiastic uptake from course teams, but copyright/visibility issues will likely have to be discussed at a policy level with different institutions, and we didn't want a blanket switch that let individual course teams turn it on without that discussion having happened. (@pomegranited: Please correct me if I'm misremembering.)

That being said, I do think we'll want to have a better experience around this for Juniper. The belt-and-suspenders option was just the lowest risk thing that let us roll out without having to address policies.

FYI @marcotuts ^ I know we're all in Ironwood + conference craziness right now, but we should talk about this after things settle down a bit.

micahl98 · 2019-03-01T16:31:03Z

Yes, I agree and understand the points well made here. It would be nice however to be able to roll this out system wide without having to specify it for each course... in my case for example, I will be treating it as a system wide option anyway.

…

On Fri, Mar 1, 2019 at 9:58 AM David Ormsbee ***@***.***> wrote: @robrap <https://github.com/robrap>: I believe that's actually because we (edX) asked that it be restricted more tightly so that it could be rolled out on a course-by-course basis. This is a powerful feature that will likely see enthusiastic uptake from course teams, but copyright/visibility issues will likely have to be discussed at a policy level with different institutions, and we didn't want a blanket switch that let individual course teams turn it on without that discussion having happened. ( @pomegranited <https://github.com/pomegranited>: Please correct me if I'm misremembering.) That being said, I do think we'll want to have a better experience around this for Juniper. The belt-and-suspenders option was just the lowest risk thing that let us roll out without having to address policies. FYI @marcotuts <https://github.com/marcotuts> ^ I know we're all in Ironwood + conference craziness right now, but we should talk about this after things settle down a bit. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/edx/edx-platform/pull/18344#issuecomment-468713317>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYBGVbipiStL7MMuUPlOwIqShM904szks5vSU4ugaJpZM4Uf0aZ> .

robrap · 2019-03-02T01:45:20Z

@ormsbee: Just making sure that it is clear that a CourseWaffleFlag allows someone to set the flag on a per course when the waffle flag itself is unset. Or, the CourseWaffleFlag let's someone turn the flag off per course when the waffle flag itself is set to true. I understand that for edx.org we are only enabling the override per course. I was just pointing out that for an Open edX instance where someone wants this on (or available) to all courses, they could just turn on the waffle flag itself, rather than having to turn the override the flag for each course. They would still need to follow @pomegranited's second step per course, but the first step documented could be done a single time for the waffle flag if so desired.
@pomegranited: Sorry if this was already clear to you, but your instructions didn't seem to show this as an option.

pomegranited · 2019-03-04T07:14:32Z

Thanks for catching this @robrap and @ormsbee ! I've updated my comment above to include both the site-wide and course-specific options, and will ensure this makes it into the docs and blog post too.

@micahl98 -- does this update meet your needs?

ormsbee · 2019-03-04T15:26:23Z

@robrap: Ah! I did not understand that about CourseWaffleFlags, though it makes perfect sense. Thank you!

robrap · 2019-03-04T18:44:25Z

@ormsbee @pomegranited: 👍

openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jun 8, 2018

symbolist changed the title ~~Fixes for courseware anonymous access.~~ [WIP] Fixes for courseware anonymous access. Jun 8, 2018

openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Jun 8, 2018

symbolist force-pushed the symbolist/navigation-for-anonymous-users branch 2 times, most recently from 8d1265c to ed71b58 Compare June 13, 2018 16:15

symbolist force-pushed the symbolist/navigation-for-anonymous-users branch from ed71b58 to 6801697 Compare June 13, 2018 17:13

symbolist force-pushed the symbolist/navigation-for-anonymous-users branch from 2d9c401 to 6801697 Compare June 14, 2018 15:07

xitij2000 approved these changes Jun 14, 2018

View reviewed changes

openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jun 14, 2018

symbolist changed the title ~~[WIP] Fixes for courseware anonymous access.~~ Fixes for courseware anonymous access. Jun 15, 2018

ormsbee approved these changes Jul 19, 2018

View reviewed changes

Fixes to sequence module for anonymous courseware access.

36b3316

symbolist force-pushed the symbolist/navigation-for-anonymous-users branch from 6801697 to 36b3316 Compare July 20, 2018 09:31

xitij2000 mentioned this pull request Jul 30, 2018

Proposal: Granular Anonymous Course Access #18134

Closed

viadanna mentioned this pull request Aug 2, 2018

Support for anonymous_view #18720

Merged

mduboseedx merged commit 6bc8b4d into openedx:master Aug 16, 2018

pomegranited deleted the symbolist/navigation-for-anonymous-users branch March 1, 2019 00:39

pkulkark mentioned this pull request Mar 11, 2019

Public Courseware Access open-craft/edx-platform#158

Merged

openedx-webhooks added merged and removed awaiting prioritization labels Jan 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for courseware anonymous access. #18344

Fixes for courseware anonymous access. #18344

symbolist commented Jun 8, 2018 •

edited

Loading

openedx-webhooks commented Jun 8, 2018

mduboseedx commented Jun 8, 2018

symbolist commented Jun 8, 2018

e0d commented Jun 11, 2018

symbolist commented Jun 13, 2018

symbolist commented Jun 13, 2018

xitij2000 left a comment •

edited

Loading

mduboseedx commented Jun 14, 2018

symbolist commented Jun 15, 2018

symbolist commented Jul 2, 2018

mduboseedx commented Jul 3, 2018

ormsbee left a comment

ormsbee Jul 19, 2018

edx-status-bot commented Jul 20, 2018

symbolist commented Jul 20, 2018

pomegranited commented Aug 14, 2018

staubina commented Aug 15, 2018

pomegranited commented Aug 16, 2018

xitij2000 commented Aug 16, 2018

pomegranited commented Aug 16, 2018

openedx-webhooks commented Aug 16, 2018

symbolist commented Aug 16, 2018

edx-pipeline-bot commented Aug 16, 2018

edx-pipeline-bot commented Aug 17, 2018

micahl98 commented Feb 28, 2019

pomegranited commented Mar 1, 2019 •

edited

Loading

robrap commented Mar 1, 2019

ormsbee commented Mar 1, 2019

micahl98 commented Mar 1, 2019 via email

robrap commented Mar 2, 2019

pomegranited commented Mar 4, 2019

ormsbee commented Mar 4, 2019

robrap commented Mar 4, 2019

Fixes for courseware anonymous access. #18344

Fixes for courseware anonymous access. #18344

Conversation

symbolist commented Jun 8, 2018 • edited Loading

openedx-webhooks commented Jun 8, 2018

mduboseedx commented Jun 8, 2018

symbolist commented Jun 8, 2018

e0d commented Jun 11, 2018

symbolist commented Jun 13, 2018

symbolist commented Jun 13, 2018

xitij2000 left a comment • edited Loading

Choose a reason for hiding this comment

mduboseedx commented Jun 14, 2018

symbolist commented Jun 15, 2018

symbolist commented Jul 2, 2018

mduboseedx commented Jul 3, 2018

ormsbee left a comment

Choose a reason for hiding this comment

ormsbee Jul 19, 2018

Choose a reason for hiding this comment

edx-status-bot commented Jul 20, 2018

symbolist commented Jul 20, 2018

pomegranited commented Aug 14, 2018

staubina commented Aug 15, 2018

pomegranited commented Aug 16, 2018

xitij2000 commented Aug 16, 2018

pomegranited commented Aug 16, 2018

openedx-webhooks commented Aug 16, 2018

symbolist commented Aug 16, 2018

edx-pipeline-bot commented Aug 16, 2018

edx-pipeline-bot commented Aug 17, 2018

micahl98 commented Feb 28, 2019

pomegranited commented Mar 1, 2019 • edited Loading

robrap commented Mar 1, 2019

ormsbee commented Mar 1, 2019

micahl98 commented Mar 1, 2019 via email

robrap commented Mar 2, 2019

pomegranited commented Mar 4, 2019

ormsbee commented Mar 4, 2019

robrap commented Mar 4, 2019

symbolist commented Jun 8, 2018 •

edited

Loading

xitij2000 left a comment •

edited

Loading

pomegranited commented Mar 1, 2019 •

edited

Loading