Alex/fix rake doc #163
Merged
Alex/fix rake doc #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -103,7 +114,7 @@ TEST_TASK_DIRS.each do |dir| | |||
| end | |||
|
|
|||
| desc "Run all tests" | |||
| task :test | |||
| task :test => :test_docs | |||
There was a problem hiding this comment.
I'm not sure I like building the docs as part of the tests. I know I don't like a browser opening to show me the docs.
There was a problem hiding this comment.
- Fixed, so tests for docs will not open a browser.
- Building docs as part of tests is good way to be sure that docs generation is not broken due to code changes.
|
Thanks for removing the browser opening. Looks good! |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Enable multicourse
aboudreault
pushed a commit
to aboudreault/edx-platform
that referenced
this pull request
Aug 14, 2014
…s-opaque-keys mattdrayer/api-roles-opaque-keys: Fixed unhandled DoesNotExist exception
prabhanshu
pushed a commit
to prabhanshu/edx-platform
that referenced
this pull request
Oct 13, 2018
identical to PR openedx#150 * todo notes (cherry picked from commit 28acb63) * anonimize video events (cherry picked from commit 0ad60e6) * cleanup (cherry picked from commit fe5fc27) * update video (cherry picked from commit 0ed4516a4d51d9d2cc188fd91fc74c75c4c6a661) * video updates (cherry picked from commit 479de0a5de9fce6da0dcca5aec0e56d45fae6645) * add video events anonimization tests (cherry picked from commit 27808f9b8e1b0b21bbec2c49a507696932630247) * update test (cherry picked from commit ed17eeae8c2a8bebc41c48b1a5a28184e8f04102) * undo an unused comment (cherry picked from commit 5210d68450237e4b0ed25071c898b06329b9a5f0) * add few comments (cherry picked from commit 8837cc9a14ba41a41b9f6d77b5ef5d51f6354262) * add test comments (cherry picked from commit ce872be41c6cea31620cafd103126be346cf419f) * fix quality (cherry picked from commit d307bfd38bf91eb6543fadd66f1c41520c4d28c5) * Addressing comments (cherry picked from commit 5cd930a26c4959cc82b5276df605edf025515111) * address some linting here and there (cherry picked from commit 084ae4b2e18720f8175889dec0284e07d265f6e6) * linting (cherry picked from commit 294ff259ffe1334e103cc9fb11b1c1925017f36d) * add username removal and few nits (cherry picked from commit 91d5bc06d116854865ec37a9022bf74ede4382f7) * remove username from task tracking logs and update the regarding test (actually also add the test by updating the name, as previously it was masked out) (cherry picked from commit 7e52585b9b5d53673cbb8d084ab7d0bc4a76780d) * add removed lline (cherry picked from commit e13846fe48211bfefeecad40810a85b7eccdc5c4) * revert the indent to match PEP (cherry picked from commit e71ee92d4968c71792755ed1b5087cfd8c80b268)
CrewS
pushed a commit
to CrewS/edx-platform-1
that referenced
this pull request
Dec 28, 2018
alanoe
pushed a commit
to alanoe/edx-platform
that referenced
this pull request
Mar 28, 2020
* Add Contact Us form customization options This commit adds personalization options for the Contact Us links on edx-platform's page. To allow for this customization, two SiteConfiguration variables were added: * CONTACT_US_ENABLE: Switch to enable/disable the Contact Us page. Setting this to False will disable the contact page and the links on the footer will disappear. * CONTACT_US_CUSTOM_LINK: If the contact page is enabled, this setting allows to set a custom URL for the Contact Us links on edx-platform. If this setting is not set, the platform will use the default contact form. * Apply suggestions from code review Co-Authored-By: xitij2000 <[email protected]>
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Co-authored-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds minor fixes and repairs documentation.
Fixes broken documentation generation after sandboxing. Adds test for documentation generation. Fixed minor RST warnings. Fixes launchy not working with Dir.chdir. Fixes broken imports after sandboxing.
@ned please review.