RESTful refactoring of /course access continued #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| return HttpResponseNotFound() | ||
|
|
||
|
|
||
| @login_required | ||
| @ensure_csrf_cookie | ||
| def course_listing(request): |
There was a problem hiding this comment.
Moved this here and renamed from user.index()
Move index access into the url Move course creation into the url Add helper methods for testing to serialize json data and set accept header.
| else: | ||
| course_creator_status = 'granted' | ||
|
|
||
| return course_creator_status |
There was a problem hiding this comment.
Might be clearer to return early, rather than set a variable and return it at the end of the function.
There was a problem hiding this comment.
I personally prefer single points of return (generally advised in "clean code"). And I wrote that code. :)
|
@singingwolfboy @cahrens May I merge this? (the test failure is a false alarm on quality) |
|
👍 |
| @@ -46,6 +45,6 @@ def login_page(request): | |||
| def howitworks(request): | |||
| "Proxy view" | |||
| if request.user.is_authenticated(): | |||
| return index(request) | |||
| return redirect('/course') | |||
There was a problem hiding this comment.
This should use Django's reverse function, rather than hard-coding the URL
|
😩 👍 😩 |
dmitchell
added a commit
that referenced
this pull request
Oct 30, 2013
RESTful refactoring of /course access continued
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move index access into the url
Move course creation into the url
Add helper methods for testing to serialize json data and set accept header.
@cahrens this is part of my story but seemed big enuf to do as a PR, plz revie
@singingwolfboy plz review