Use XBlock handlers in the LMS ... #1531
Conversation
|
looks like a lot of XModule unit tests are failing... eek |
|
Yeah, I'm working on that. The set of changes should be small, though. |
| render.handle_xblock_callback( | ||
| None, | ||
| 'dummy/course/id', | ||
| quote_slashes('invalid Location'), |
There was a problem hiding this comment.
seems like using quote_slashes is unnecessary for the string 'invalid Location'
|
Did a first-pass and it looks pretty good. Will do a more thorough pass when tests pass. Also consider having someone from Studio look at this - there are some CMS changes here. |
|
|
||
| descriptor = modulestore().get_item(location) | ||
| instance = load_preview_module(request, preview_id, descriptor) | ||
| instance = load_preview_module(request, descriptor) |
There was a problem hiding this comment.
Maybe I'm just not up on how the CMS will use handlers: is it a given that a handler in the CMS will imply "preview"? Or is this a misleading use of the word "preview"?
There was a problem hiding this comment.
No, you're right, this is preview only, and should be named that way.
|
Take care of a few things, and then 👍 |
| 'input_[]_3': 'test', | ||
| 'input_4': None, | ||
| # 'input_5' intentionally left unset, | ||
| 'input_6': 5}) |
There was a problem hiding this comment.
This multiline split doesn't seem right (closing paren on final line; would be neater to put the first dictionary entry on line 336 not 335) - split the same way it's split in test_peer_grading.py l 33
Why is input 5 intentionally left unset? I might prefer that in a comment above the declaration of valid_get_dict
| self.module = SelfAssessmentModule(get_test_system(), self.location, | ||
| system = get_test_system() | ||
| system.xmodule_instance = Mock(scope_ids=Mock(usage_id='dummy-usage-id')) | ||
| self.module = SelfAssessmentModule(system, self.location, |
There was a problem hiding this comment.
system & self.location on their own lines
|
Unit tests for the new functions in |
| @@ -89,6 +89,7 @@ transifex-client==0.9.1 | |||
|
|
|||
| # Used for testing | |||
| coverage==3.6 | |||
| ddt==0.4.0 | |||
There was a problem hiding this comment.
@jtauber: This library is LGPL. I'm going to merge this w/o waiting for your OK, but let me know if we need to, and we can pull it out. It's only actually used during tests.
|
If you rebase you should be able to fix the quality build - I merged #1554 yesterday. |
Adds xblock handler_url support to the LMS, and makes handle_ajax use that code. [LMS-230] [LMS-229]
Use XBlock handlers in the LMS ...
... and use them to implement ajax_url for XModule compatibility