Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: upgrade to Django 4.2 LTS #357

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat!: upgrade to Django 4.2 LTS #357

merged 1 commit into from
Oct 30, 2023

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Oct 26, 2023 •
edited
Loading

Upgrading django42.

@awais786 awais786 requested a review from a team as a code owner October 26, 2023 13:01
awais786
awais786 commented Oct 26, 2023
View reviewed changes
requirements/django.txt
@@ -1 +1 @@
django==3.2.22
django==4.2.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django version.

awais786
awais786 commented Oct 26, 2023
View reviewed changes
requirements/base.txt
# via pyjwt
django==3.2.22
django==4.2.6
Copy link
Contributor Author

@awais786 awais786 Oct 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django version.

UsamaSadiq
UsamaSadiq approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Verified that make upgrade is also working successfully through github action.

mattcarter
mattcarter approved these changes Oct 30, 2023
View reviewed changes
Copy link

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@iamsobanjaved iamsobanjaved merged commit ae4ea9e into master Oct 30, 2023
8 checks passed
@iamsobanjaved iamsobanjaved deleted the upgrading-django42 branch October 30, 2023 19:38
iamsobanjaved added a commit that referenced this pull request Nov 1, 2023
@iamsobanjaved
Revert "feat!: upgrade to Django 4.2 LTS (#357)"
5c75196 
This reverts commit ae4ea9e.
@iamsobanjaved iamsobanjaved mentioned this pull request Nov 1, 2023
Merged
mattcarter pushed a commit that referenced this pull request Nov 1, 2023
@iamsobanjaved
Revert "feat!: upgrade to Django 4.2 LTS (#357)" (#363)
3345487 
This reverts commit ae4ea9e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UsamaSadiq UsamaSadiq UsamaSadiq approved these changes

@mattcarter mattcarter mattcarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awais786 @mattcarter @UsamaSadiq @iamsobanjaved