fix: Added support for Django42 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
requested changes
Sep 20, 2023
There was a problem hiding this comment.
make validate command installs Django==3.2.20 from requirements/base.txt before running tests which overrides the Django version installed by tox when setting up the environment so we won't be able to run tests with multiple django versions in CI.
The current CI Djanog 4.2 checks are also running tests with Django 3.2 [See the Django40 warnings still being produced in the logs for proof].
In short, we can remove this addition of django42 in the current PR and do the jump directly from Django 32 to Django42 in the follow up Upgrade PR.
UsamaSadiq
force-pushed
the
zshkoor/django42-support
branch
from
0e42ae5
to
4f3f3b0
Compare
UsamaSadiq
approved these changes
Oct 5, 2023
iamsobanjaved
approved these changes
Oct 5, 2023
| @@ -33,7 +33,7 @@ class HasAccessToken(BasePermission): | |||
| def has_permission(self, request, view): | |||
| if getattr(settings, 'DISABLE_TOKEN_CHECK', False): | |||
| return True | |||
| token = request.META.get('HTTP_X_ANNOTATOR_AUTH_TOKEN', '') | |||
| token = request.headers.get('x-annotator-auth-token', '') | |||
There was a problem hiding this comment.
Reason for change: https://docs.djangoproject.com/en/4.2/releases/2.2/#requests-and-responses
zacharis278
approved these changes
Oct 6, 2023
jansenk
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #344