Skip to content

Commit

Permalink
feat!: upgrade to Django 4.2 LTS
Browse files Browse the repository at this point in the history
  • Loading branch information
UsamaSadiq committed Oct 5, 2023
1 parent f0f5b28 commit d3f3814
Show file tree
Hide file tree
Showing 12 changed files with 125 additions and 200 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,8 @@ jobs:
max-parallel: 4
matrix:
python-version: ['py38']
django-version: ['django32', 'django42']
db-version: ['mysql57', 'mysql80']
# excluding mysql5.7 with Django 4.2 since Django 4.2 has
# dropped support for MySQL<8
exclude:
- django-version: 'django42'
db-version: 'mysql57'
django-version: ['django42']
db-version: ['mysql80']

steps:
- uses: actions/checkout@v2
Expand Down
11 changes: 0 additions & 11 deletions .travis/docker-compose-travis.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
version: "2"

services:
mysql57:
image: mysql:5.7
container_name: mysql57
command: mysqld --character-set-server=utf8 --collation-server=utf8_general_ci
environment:
MYSQL_ROOT_PASSWORD: ""
MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
MYSQL_USER: "notes001"
MYSQL_PASSWORD: "secret"
MYSQL_DATABASE: "edx_notes_api"
mysql80:
image: mysql:8.0
container_name: mysql80
Expand Down Expand Up @@ -49,7 +39,6 @@ services:
- ..:/edx/app/edx_notes_api/edx_notes_api
command: tail -f /dev/null
depends_on:
- "mysql57"
- "mysql80"
- "es"
environment:
Expand Down
15 changes: 14 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,21 @@ develop: requirements test.requirements
piptools: ## install pinned version of pip-compile and pip-sync
pip install -r requirements/pip-tools.txt

define COMMON_CONSTRAINTS_TEMP_COMMENT
# This is a temporary solution to override the real common_constraints.txt\n# In edx-lint, until the pyjwt constraint in edx-lint has been removed.\n# See BOM-2721 for more details.\n# Below is the copied and edited version of common_constraints\n
endef
COMMON_CONSTRAINTS_TXT=requirements/common_constraints.txt
.PHONY: $(COMMON_CONSTRAINTS_TXT)
$(COMMON_CONSTRAINTS_TXT):
wget -O "$(@)" https://raw.githubusercontent.com/edx/edx-lint/master/edx_lint/files/common_constraints.txt || touch "$(@)"
echo "$(COMMON_CONSTRAINTS_TEMP_COMMENT)" | cat - $(@) > temp && mv temp $(@)

upgrade: export CUSTOM_COMPILE_COMMAND=make upgrade
upgrade: piptools ## update the requirements/*.txt files with the latest packages satisfying requirements/*.in
# This is a temporary solution to override the real common_constraints.txt
# In edx-lint, until the pyjwt constraint in edx-lint has been removed.
# See BOM-271 for more details.
sed -i.'' 's/Django<4.0//g' requirements/common_constraints.txt
# Make sure to compile files after any other files they include!
pip-compile --upgrade -o requirements/travis.txt requirements/travis.in
pip-compile --upgrade --rebuild --allow-unsafe -o requirements/pip.txt requirements/pip.in
Expand All @@ -77,4 +90,4 @@ upgrade: piptools ## update the requirements/*.txt files with the latest package
pip-compile --upgrade -o requirements/test.txt requirements/test.in
# Let tox control the Django version for tests
grep -e "^django==" requirements/base.txt > requirements/django.txt
sed -i '/^[dD]jango==/d' requirements/test.txt
sed -i.'' '/^[dD]jango==/d' requirements/test.txt
92 changes: 34 additions & 58 deletions requirements/base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,46 +4,41 @@
#
# make upgrade
#
asgiref==3.6.0
asgiref==3.7.2
# via django
certifi==2022.12.7
certifi==2023.7.22
# via
# elasticsearch
# requests
cffi==1.15.1
cffi==1.16.0
# via
# cryptography
# pynacl
chardet==3.0.4
# via requests
click==8.1.3
click==8.1.7
# via edx-django-utils
coreapi==2.3.3
# via drf-yasg
coreschema==0.0.4
# via
# coreapi
# drf-yasg
cryptography==40.0.1
cryptography==41.0.4
# via pyjwt
django==3.2.20
django==3.2.22
# via
# -c https://raw.githubusercontent.com/edx/edx-lint/master/edx_lint/files/common_constraints.txt
# -r requirements/base.in
# django-cors-headers
# django-crum
# django-nine
# django-waffle
# djangorestframework
# drf-jwt
# drf-yasg
# edx-django-release-util
# edx-django-utils
# edx-drf-extensions
django-cors-headers==3.14.0
django-cors-headers==4.2.0
# via -r requirements/base.in
django-crum==0.7.9
# via edx-django-utils
django-elasticsearch-dsl==7.3
django-elasticsearch-dsl==7.4
# via
# -c requirements/constraints.txt
# -r requirements/base.in
Expand All @@ -52,7 +47,7 @@ django-elasticsearch-dsl-drf==0.22.5
# via -r requirements/base.in
django-nine==0.2.7
# via django-elasticsearch-dsl-drf
django-waffle==3.0.0
django-waffle==4.0.0
# via
# edx-django-utils
# edx-drf-extensions
Expand All @@ -65,17 +60,17 @@ djangorestframework==3.14.0
# edx-drf-extensions
drf-jwt==1.19.2
# via edx-drf-extensions
drf-yasg==1.21.5
drf-yasg==1.21.7
# via -r requirements/base.in
edx-django-release-util==1.2.0
edx-django-release-util==1.3.0
# via -r requirements/base.in
edx-django-utils==5.3.0
edx-django-utils==5.7.0
# via
# -r requirements/base.in
# edx-drf-extensions
edx-drf-extensions==8.4.1
edx-drf-extensions==8.10.0
# via -r requirements/base.in
edx-opaque-keys==2.3.0
edx-opaque-keys==2.5.1
# via edx-drf-extensions
elasticsearch==7.13.4
# via
Expand All @@ -90,46 +85,35 @@ elasticsearch-dsl==7.4.1
# -r requirements/base.in
# django-elasticsearch-dsl
# django-elasticsearch-dsl-drf
future==0.18.3
# via pyjwkest
gunicorn==20.1.0
gunicorn==21.2.0
# via -r requirements/base.in
idna==2.10
# via requests
inflection==0.5.1
# via drf-yasg
itypes==1.2.0
# via coreapi
jinja2==3.1.2
# via coreschema
markupsafe==2.1.2
# via jinja2
mysqlclient==2.1.1
mysqlclient==2.2.0
# via -r requirements/base.in
newrelic==4.8.0.110
# via
# -c requirements/constraints.txt
# -r requirements/base.in
# edx-django-utils
packaging==23.0
packaging==23.2
# via
# django-nine
# drf-yasg
# gunicorn
path-py==9.1
# via
# -c requirements/constraints.txt
# -r requirements/base.in
pbr==5.11.1
# via stevedore
psutil==5.9.4
psutil==5.9.5
# via edx-django-utils
pycparser==2.21
# via cffi
pycryptodomex==3.17
# via pyjwkest
pyjwkest==1.4.2
# via edx-drf-extensions
pyjwt[crypto]==2.6.0
pyjwt[crypto]==2.8.0
# via
# -r requirements/base.in
# drf-jwt
Expand All @@ -142,51 +126,43 @@ python-dateutil==2.4.0
# via
# -c requirements/constraints.txt
# -r requirements/base.in
# edx-drf-extensions
# elasticsearch-dsl
pytz==2023.3
pytz==2023.3.post1
# via
# django
# djangorestframework
# drf-yasg
pyyaml==6.0
# via edx-django-release-util
pyyaml==6.0.1
# via
# drf-yasg
# edx-django-release-util
requests==2.25.0
# via
# -c requirements/constraints.txt
# -r requirements/base.in
# coreapi
# edx-drf-extensions
# pyjwkest
ruamel-yaml==0.17.21
# via drf-yasg
ruamel-yaml-clib==0.2.7
# via ruamel-yaml
semantic-version==2.10.0
# via edx-drf-extensions
six==1.16.0
# via
# django-elasticsearch-dsl
# django-elasticsearch-dsl-drf
# edx-django-release-util
# edx-drf-extensions
# elasticsearch-dsl
# pyjwkest
# python-dateutil
sqlparse==0.4.3
sqlparse==0.4.4
# via django
stevedore==5.0.0
stevedore==5.1.0
# via
# edx-django-utils
# edx-opaque-keys
uritemplate==4.1.1
typing-extensions==4.8.0
# via
# coreapi
# drf-yasg
urllib3==1.26.15
# asgiref
# edx-opaque-keys
uritemplate==4.1.1
# via drf-yasg
urllib3==1.26.17
# via
# elasticsearch
# requests

# The following packages are considered to be unsafe in a requirements file:
# setuptools
Empty file.
5 changes: 2 additions & 3 deletions requirements/constraints.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Version constraints for pip installation.
# Version constraints for pip-installation.
#
# This file doesn't install any packages. It specifies version constraints
# that will be applied if a package is needed.
Expand All @@ -8,8 +8,7 @@
# pin when possible. Writing an issue against the offending project and
# linking to it here is good.

# This file contains all common constraints for edx-repos
-c https://raw.githubusercontent.com/edx/edx-lint/master/edx_lint/files/common_constraints.txt
-c common_constraints.txt

astroid==1.6.6
requests==2.25.0
Expand Down
2 changes: 1 addition & 1 deletion requirements/django.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
django==3.2.20
django==3.2.22
19 changes: 13 additions & 6 deletions requirements/pip-tools.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,27 @@
#
# make upgrade
#
build==0.10.0
build==1.0.3
# via pip-tools
click==8.1.3
click==8.1.7
# via pip-tools
packaging==23.0
importlib-metadata==6.8.0
# via build
pip-tools==6.12.3
packaging==23.2
# via build
pip-tools==7.3.0
# via -r requirements/pip-tools.in
pyproject-hooks==1.0.0
# via build
tomli==2.0.1
# via build
wheel==0.40.0
# via
# build
# pip-tools
# pyproject-hooks
wheel==0.41.2
# via pip-tools
zipp==3.17.0
# via importlib-metadata

# The following packages are considered to be unsafe in a requirements file:
# pip
Expand Down
6 changes: 3 additions & 3 deletions requirements/pip.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
#
# make upgrade
#
wheel==0.40.0
wheel==0.41.2
# via -r requirements/pip.in

# The following packages are considered to be unsafe in a requirements file:
pip==23.0.1
pip==23.2.1
# via -r requirements/pip.in
setuptools==67.6.1
setuptools==68.2.2
# via -r requirements/pip.in
Loading

0 comments on commit d3f3814

Please sign in to comment.