Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feanil/fix tox ini #65

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Feanil/fix tox ini #65

merged 2 commits into from
Sep 23, 2020

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Sep 23, 2020

Travis was looking to test with django 2.2 and 3.0 but tox didn't
support that.

Travis was looking to test with django 2.2 and 3.0 but tox didn't
support that.
@jinder1s
Copy link
Contributor

FYI, the py35 tests have been failing on master. I've been trying to debug it locally, but haven't been able to figure out why it fails(The tests work locally on my laptop)

@feanil
Copy link
Contributor Author

feanil commented Sep 23, 2020

It looks like the failure is due to a new release of importlib-metadata which is pinned to an older version by tox. Our various requirement file gymnastics is causing some conflicts. We could fix or wait till tox updates. I'm testing a fix in the app I just made from the cookiecutter.

@feanil
Copy link
Contributor Author

feanil commented Sep 23, 2020

I'm inclined to not fix it since it's only an issue in python 3.5.

@feanil feanil merged commit 028d0ab into master Sep 23, 2020
@feanil feanil deleted the feanil/fix_tox_ini branch September 23, 2020 20:14
@feanil feanil restored the feanil/fix_tox_ini branch October 1, 2020 18:42
@feanil feanil deleted the feanil/fix_tox_ini branch October 1, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants