Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct country typo🇺🇦 #413

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

apexDev37
Copy link
Contributor

Description:
Simple edit suggestion to fix a typo in the config.yaml file for the django-app edx-cookiecutter. Change the descriptive comment for the locale, uk from "Ukranian" to "Ukrainian", which is the correct demonym for people or things related to Ukraine 🇺🇦.

Additional:

  • This typo error was raised by codespell, a tool designed to catch common misspellings in code, running as a pre-commit hook in the code-quality tool, pre-commit.
  • For more context, this occurred in my local development environment while building an Open edX, Django app plugin.

Here is the error output from pre-commit:

codespell................................................................Failed
- hook id: codespell
- exit code: 65

openedx_plugin_greeting/conf/locale/config.yaml:75: Ukranian ==> Ukrainian

Recommendation:
Consider using the pre-commit automation tool to enable contributors to easily add early CI checks into their local dev environments on each commit.

Testing:
This PR does not introduce any code changes to the functional code of this repo.

Merge checklist:
Check off if complete or not applicable:

  • [✔] Changelog record added
  • [✔] Documentation updated (not only docstrings)
  • [✔] Fixup commits are squashed away
  • [✔] Unit tests added/updated
  • [✔] Manual testing instructions provided
  • [✔] Noted any: Concerns, dependencies, deadlines, tickets

Correct typo error in comment for locale `uk`.
- Change "Ukranian" to "Ukrainian".

[Reason]
The correct demonym for people or things related to Ukraine is "Ukrainian."
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 2, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @apexDev37! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@apexDev37 apexDev37 changed the title fix: Correct country typo 🇺🇦 fix: Correct country typo🇺🇦 Dec 3, 2023
@timmc-edx timmc-edx merged commit 2457659 into openedx:master Dec 4, 2023
5 checks passed
@openedx-webhooks
Copy link

@apexDev37 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants