Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Link to getting-started instructions rather than templating them #405

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

timmc-edx
Copy link
Contributor

See #396 for details.

Also, promote "Deploying" header, which had previously been under "Getting Started".

Merge checklist:
Check off if complete or not applicable:

  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, deadlines, tickets

See #396 for details.

Also, promote "Deploying" header, which had previously been under "Getting
Started".
Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion

timmc-edx added a commit to openedx/open-edx-proposals that referenced this pull request Nov 7, 2023
This follows some discussion in the cookiecutters repo:
openedx/edx-cookiecutters#405
timmc-edx added a commit to openedx/open-edx-proposals that referenced this pull request Nov 8, 2023
This follows some discussion in the cookiecutters repo:
openedx/edx-cookiecutters#405
Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmc-edx timmc-edx merged commit 0debc8c into master Nov 8, 2023
5 checks passed
@timmc-edx timmc-edx deleted the timmc/getting-started branch November 8, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants