Refactor to reduce duplication in post_gen hooks, plus other fixes #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
reviewed
Jul 28, 2023
nedbat
force-pushed
the
nedbat/common-hook-code
branch
from
ab160a6
to
3085544
Compare
timmc-edx
reviewed
Jul 31, 2023
...ter-django-ida/{{cookiecutter.repo_name}}/{{cookiecutter.project_name}}/settings/devstack.py
Outdated
Show resolved
Hide resolved
nedbat
force-pushed
the
nedbat/common-hook-code
branch
from
3085544
to
a70363c
Compare
|
@timmc-edx ready to go. |
timmc-edx
reviewed
Aug 4, 2023
tests/test_cookiecutter_xblock.py
Outdated
| @@ -60,6 +60,8 @@ def fixture_options_baked(cookies_session, request, custom_template): | |||
| baked result. | |||
| """ | |||
| with bake_in_temp_dir(cookies_session, extra_context=request.param, template=custom_template): | |||
| sh.make('upgrade') | |||
| sh.pip('install', '-r', 'requirements/base.txt') | |||
There was a problem hiding this comment.
Just noticing now that this was base.txt. Does it still work if we switch it to test.txt? 🤞
There was a problem hiding this comment.
Changed. It works. Now all four copies of this fixture use test.txt.
nedbat
force-pushed
the
nedbat/common-hook-code
branch
from
a70363c
to
9da60b3
Compare
timmc-edx
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can split this into separate pull requests if needed. I got a bit aggressive with some changes....
Merge checklist:
Check off if complete or not applicable: