Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jswope00/change external refs to internal #759

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Jswope00/change external refs to internal #759

merged 8 commits into from
Jan 13, 2025

Conversation

jswope00
Copy link
Contributor

@jswope00 jswope00 commented Jan 9, 2025

Removing the intersphinx_mapping setting that creates links to legacy docs, and fixing all breaking links that result.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 9, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 9, 2025 •
edited
Loading

Thanks for the pull request, @jswope00!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/docs-openedx-org-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@jswope00 jswope00 requested a review from sarina January 9, 2025 00:09
@sarina
Copy link
Contributor

sarina commented Jan 9, 2025

@jswope00 ping me when this is ready for review, or if you need any help with things

@jswope00 jswope00 linked an issue Jan 12, 2025 that may be closed by this pull request
The video_process_overview.html should be modified for Open edX #630
Closed
@sarina sarina marked this pull request as ready for review January 13, 2025 16:28
sarina
sarina approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggested changes, merge when you're satisfied

source/site_ops/how-tos/enable_public_course_content.rst Outdated Show resolved Hide resolved
source/site_ops/how-tos/enable_public_course_content.rst Outdated Show resolved Hide resolved
source/site_ops/how-tos/enable_public_course_content.rst Outdated Show resolved Hide resolved
source/site_ops/how-tos/enable_public_course_content.rst Outdated Show resolved Hide resolved
@jswope00 jswope00 merged commit ad00c8a into openedx:main Jan 13, 2025
2 checks passed
BryanttV pushed a commit to BryanttV/docs.openedx.org that referenced this pull request Jan 15, 2025
@jswope00 @sarina @BryanttV
Jswope00/change external refs to internal (openedx#759)
f659f54 
* Remove the intersphinx_mapping to legacy docs

* Change breaking references to external docs to internal

* Add Video Guidelines Doc

* Add Enable Public Course Content How-To

* Modify all external links to internal

* Resolve build errors

* Improve references to Open edX replacing edx.org

Co-authored-by: Sarina Canelake <[email protected]>

---------

Co-authored-by: Sarina Canelake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarina sarina sarina approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The video_process_overview.html should be modified for Open edX
3 participants
@jswope00 @openedx-webhooks @sarina