Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinned importlib-metadata constraint #93

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq marked this pull request as ready for review October 12, 2020 06:49
@regisb
Copy link
Contributor

regisb commented Oct 12, 2020

Hi @UsamaSadiq! I checked your other PRs but I don't understand what problem this is fixing. You mention here that "On Python<3.8, importlib-metadata==2.0.0 causes dependency conflicts because of the pinned constraint python<3.8". Did you mean instead: "... because of the pinned constraint python>=3.8"?

Maybe if you could paste here the error stacktrace that would help clarify the issue?

@UsamaSadiq
Copy link
Member Author

Hi @UsamaSadiq! I checked your other PRs but I don't understand what problem this is fixing. You mention here that "On Python<3.8, importlib-metadata==2.0.0 causes dependency conflicts because of the pinned constraint python<3.8". Did you mean instead: "... because of the pinned constraint python>=3.8"?

Maybe if you could paste here the error stacktrace that would help clarify the issue?

Hi @regisb, tox and virtualenv both had the constraint importlib-metadata>=0.12,<2; python<3.8 which was causing conflicts in the builds when ran with python3.5 or python3.6. We had to wait for the fix in both packages so we added the constraint in the meanwhile. Now that constraint has been updated in both tox and virtualenv so I've removed the pin from the repo too. I hope this clarifies the situation.

@regisb
Copy link
Contributor

regisb commented Oct 12, 2020

Ok thanks!

@regisb regisb merged commit 7f07ec1 into master Oct 12, 2020
@regisb regisb deleted the usamasadiq/unpin-importlib-metadata branch October 12, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants