fix: handle draft only courses properly in archive_courses command #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def verify_archived(self, course, mangle_title, mangle_end_date): | ||
| for c in [course, course.draft_version]: | ||
| def verify_archived(self, course, mangle_title, mangle_end_date, is_official=True): | ||
| for c in ([course, course.draft_version] if is_official else [course]): |
There was a problem hiding this comment.
To confirm, the [course] in else is draft version, right? It is confusing because the other option has course, course.draft_version which then immediately takes it to mind that other [course] is non-draft in else.
There was a problem hiding this comment.
Yes. I have added a comment to clarify this.
course_discovery/apps/course_metadata/management/commands/tests/test_archive_courses.py
Outdated
Show resolved
Hide resolved
DawoudSheraz
approved these changes
Jan 17, 2025
AfaqShuaib09
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4289
Currently the
archive_coursecommand ignores courses without official versions. We change the behavior so that they are not.