feat: add vertical models in tagging app #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
force-pushed
the
afaq/prod-4280
branch
2 times, most recently
from
c044fe0 to
f4ae8ee
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-4279
branch
from
dc3b42b to
2631aed
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-4280
branch
2 times, most recently
from
2293acd to
e1a1f9b
Compare
zawan-ila
reviewed
Jan 20, 2025
AfaqShuaib09
force-pushed
the
afaq/prod-4280
branch
from
f92312f to
10d00e4
Compare
zawan-ila
approved these changes
Jan 20, 2025
AfaqShuaib09
force-pushed
the
afaq/prod-4280
branch
from
34abf7c to
cd0469c
Compare
Comment on lines
115
to
112
| self.coursevertical_admin.save_model(request, self.coursevertical, None, False) | ||
|
|
||
| def test_save_model_as_allowed_group_user(self): | ||
| """Verify that user in allowed group can save course vertical.""" | ||
| self.regular_user.groups.add(self.allowed_group) | ||
| request = MockRequest(self.regular_user) | ||
| self.coursevertical_admin.save_model(request, self.coursevertical, None, False) |
There was a problem hiding this comment.
same assertion comments.
There was a problem hiding this comment.
However, it's only for checking permissions, as it will raise a permission issue in case of a non-allowed user group. I'm now adding some assertions by changing a field
AfaqShuaib09
force-pushed
the
afaq/prod-4280
branch
from
cd0469c to
b32e3d0
Compare
Comment on lines
+56
to
+60
| Vertical, on_delete=models.CASCADE, null=True, blank=True, related_name="%(class)s_verticals" | ||
| ) | ||
| sub_vertical = models.ForeignKey( | ||
| SubVertical, on_delete=models.CASCADE, null=True, blank=True, related_name="%(class)s_sub_verticals" | ||
| ) |
There was a problem hiding this comment.
Why do we do this %(class)? The migrations do not translate this to anything.
There was a problem hiding this comment.
%(class) will pick the class name from child class
https://docs.djangoproject.com/en/dev/topics/db/models/#be-careful-with-related-name-and-related-query-name
Comment on lines
+96
to
+97
| if not self.vertical: | ||
| self.vertical = self.sub_vertical.vertical # Auto-assign vertical if it's not set |
DawoudSheraz
approved these changes
Jan 21, 2025
AfaqShuaib09
force-pushed
the
afaq/prod-4280
branch
from
28bffa6 to
ab65db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4280
This PR adds the model related to vertical tagging.