Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variant_id field to CourseRun model to support external LOBs #4169

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

AfaqShuaib09
Copy link
Contributor

@AfaqShuaib09 AfaqShuaib09 commented Nov 2, 2023

PROD-3733

This PR adds the variant_id field to CourseRun model to support External LOBs (ExecEd, Bootcamps).

API response

image

@AfaqShuaib09 AfaqShuaib09 marked this pull request as draft November 2, 2023 12:19
@AfaqShuaib09 AfaqShuaib09 marked this pull request as ready for review November 3, 2023 15:53
@AfaqShuaib09 AfaqShuaib09 changed the title [WIP] feat: add variant_id field to CourseRun model to support external LOBs feat: add variant_id field to CourseRun model to support external LOBs Nov 3, 2023
Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, otherwise looks good. I have not tested it on local but the changes look good enough.

@AfaqShuaib09 AfaqShuaib09 merged commit a9bfe2b into master Nov 6, 2023
13 checks passed
@AfaqShuaib09 AfaqShuaib09 deleted the afaq/prod_3732 branch November 6, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants