feat: organization field tracker #4138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
changed the title
AfaqShuaib09
force-pushed
the
afaq/prod-3582
branch
from
67a0878 to
de45811
Compare
DawoudSheraz
reviewed
Oct 3, 2023
DawoudSheraz
reviewed
Oct 3, 2023
DawoudSheraz
reviewed
Oct 5, 2023
| @@ -301,7 +307,7 @@ class Organization(ManageHistoryMixin, CachedMixin, TimeStampedModel): | |||
| def has_changed(self): | |||
| if not self.pk: | |||
| return False | |||
| return self.has_model_changed() | |||
| return self.has_model_changed(external_keys=[self.partner], excluded_fields=['data_modified_timestamp']) | |||
There was a problem hiding this comment.
nit: you wont need external keys here. This will only be effective if the partner is updated in the same session as Organization. Both Org and Partners are handled differently in admin. This is just adding an unnecessary computation. For Partner changes to update timestamp on Organization, we would need a pre_Save signal on Partner save, which is not needed at this point as Partner object rarely changes.
DawoudSheraz
reviewed
Oct 5, 2023
Comment on lines
1791
to
1800
| def test_data_modified_timestamp_model_related_field_change(self): | ||
| """ | ||
| Verify data modified timestamp changes on related field changes in Organization Model | ||
| """ | ||
| org = factories.OrganizationFactory(partner=PartnerFactory(name='test partner', short_code='test_ptr')) | ||
| data_modified_timestamp = org.data_modified_timestamp | ||
| org.partner.short_code = 't_code' | ||
| org.save() | ||
| assert data_modified_timestamp < org.data_modified_timestamp | ||
|
|
There was a problem hiding this comment.
If you address the external keys comment above, this test will fail. In this test, the partner is accessed from org object and is applicable for external_keys check. But in actual use-case, the org handling is happening via Admin.
DawoudSheraz
approved these changes
Oct 5, 2023
AfaqShuaib09
force-pushed
the
afaq/prod-3582
branch
2 times, most recently
from
91f1b79 to
7c01d50
Compare
zawan-ila
approved these changes
Oct 9, 2023
AfaqShuaib09
force-pushed
the
afaq/prod-3582
branch
from
7c01d50 to
a2ab468
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-3582
branch
from
e4b803e to
dd3da23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3582
This PR adds data modified timestamp field for Organization model