Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] Please remove django 3.2 test gating in license-manager #897

Closed
macdiesel opened this issue Sep 26, 2023 · 5 comments
Closed
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@macdiesel
Copy link

Firm Name

2u

Urgency

Medium (< 2 weeks)

Requested Change

Currently in the process of upgrading Django to 4.2.

Could you please remove django 3.2 test gating in license-manager.

There will be a subsequent ask to turn this on for 4.2 once openedx/license-manager#525 is merged.

Reasoning

Upgrading Django.

@macdiesel macdiesel added the github-request Request for change to access level or settings in the openedx GitHub organization. label Sep 26, 2023
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@brian-smith-tcril brian-smith-tcril self-assigned this Sep 26, 2023
@brian-smith-tcril
Copy link

I'm not sure what test gating you're referring to, I only see 2 required checks on that repo

image

Am I not looking in the right spot?

@brian-smith-tcril
Copy link

@macdiesel I didn't ping you in my previous response so I figured I'd follow up.

@macdiesel
Copy link
Author

macdiesel commented Sep 28, 2023 via email

@brian-smith-tcril
Copy link

GitHub shows which checks will block merging any given PR by noting them as "Required"

image

Since it's not on I'm going to go close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

2 participants