chore: Resolve RemovedInDjango40Warning warnings. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopappas
force-pushed
the
cpappas/tech-debt-athon
branch
from
877f7c1 to
892316d
Compare
macdiesel
approved these changes
Nov 1, 2021
dianakhuang
approved these changes
Nov 1, 2021
jmbowman
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
If you find yourself needing to do more things like this, there's a codemod utility at https://github.com/adamchainz/django-upgrade that can do most of it for you (Arbi-BOM is currently running it across edx-platform).
auth_backends/urls.py
Outdated
| @@ -2,15 +2,16 @@ | |||
|
|
|||
| Add these to your project's `urlpatterns` to avoid duplicating code. | |||
| """ | |||
| from django.conf.urls import url, include | |||
| from django.conf.urls import include | |||
| from django.urls import re_path | |||
There was a problem hiding this comment.
include is also now available via django.urls, so this whole thing can be simplified to from django.urls import include, re_path.
There was a problem hiding this comment.
sounds good, will change
| url('', include('social_django.urls', namespace='social')), | ||
| re_path(r'^login/$', EdxOAuth2LoginView.as_view(), name='login'), | ||
| re_path(r'^logout/$', EdxOAuth2LogoutView.as_view(), name='logout'), | ||
| re_path('', include('social_django.urls', namespace='social')), |
There was a problem hiding this comment.
We'll probably want to change these to use path() later, but I'm fine with punting that until we have more experience and docs for doing it.
christopappas
force-pushed
the
cpappas/tech-debt-athon
branch
from
892316d to
68f175b
Compare
christopappas
force-pushed
the
cpappas/tech-debt-athon
branch
from
68f175b to
b356c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use
django.urlsinstead ofdjango.conf.urlsto resolve REmovedInDjango40WarningsJIRA:
No associated ticket.
Additional Details
Reviewers:
Merge checklist:
Post merge:
finished.