-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for CCX courses #44
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
788d9b8
to
8d6b3f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can you make a dbt test that covers the cases in the description to make sure we don't break this in the future?
cd55c21
to
061858b
Compare
061858b
to
68260d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do video ids also get CCX versions?
Yes, but that's processed at transforming in ERB which should be fixed by this one: openedx/event-routing-backends#392 |
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR allows us to get the course organization for CCX courses and fixes the
get_problem_id
regex to include '@' which is part of the URL for CCX courses.After querying:
select * from reporting.fact_problem_responses format Vertical
it matches both course formats:Depends on: openedx/tutor-contrib-aspects#607