Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for CCX courses #44

Merged
merged 3 commits into from
Feb 21, 2024
Merged

feat: add support for CCX courses #44

merged 3 commits into from
Feb 21, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Feb 14, 2024

Description

This PR allows us to get the course organization for CCX courses and fixes the get_problem_id regex to include '@' which is part of the URL for CCX courses.

After querying: select * from reporting.fact_problem_responses format Vertical it matches both course formats:

Row 3:
──────
emission_time:              2024-02-19 15:29:41
org:                        edunext
course_key:                 course-v1:edunext+demo+demo
course_name:                Demo
course_run:                 demo
problem_id:                 block-v1:edunext+demo+demo+type@problem+block@3c1646f7133a4c5fb4557d649e22c251
problem_name:               Checkboxes
problem_name_with_location: 2:2:0 - Checkboxes
actor_id:                   9bd74238-97cf-4bff-ab96-d98a6006cba5
responses:                  ["a correct answer", "a correct answer"]
success:                    true
attempts:                   1

Row 4:
──────
emission_time:              2024-02-16 22:15:14
org:                        edunext
course_key:                 ccx-v1:edunext+demo+demo+ccx@1
course_name:                demo CXX
course_run:                 ccx@1
problem_id:                 ccx-block-v1:edunext+demo+demo+ccx@1+type@problem+block@3c1646f7133a4c5fb4557d649e22c251
problem_name:               Checkboxes
problem_name_with_location: 2:2:0 - Checkboxes
actor_id:                   9bd74238-97cf-4bff-ab96-d98a6006cba5
responses:                  ["a correct answer", "an incorrect answer", "a correct answer"]
success:                    false
attempts:                   6

Depends on: openedx/tutor-contrib-aspects#607

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 14, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 14, 2024

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 marked this pull request as ready for review February 19, 2024 16:03
@Ian2012 Ian2012 changed the title feat: get org from ccx course url feat: add support for CCX courses Feb 19, 2024
@Ian2012 Ian2012 requested a review from bmtcril February 19, 2024 16:07
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you make a dbt test that covers the cases in the description to make sure we don't break this in the future?

@Ian2012 Ian2012 force-pushed the cag/ccx-support branch 12 times, most recently from cd55c21 to 061858b Compare February 20, 2024 16:18
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do video ids also get CCX versions?

@Ian2012
Copy link
Contributor Author

Ian2012 commented Feb 20, 2024

Yes, but that's processed at transforming in ERB which should be fixed by this one: openedx/event-routing-backends#392

@Ian2012 Ian2012 merged commit 1a15455 into main Feb 21, 2024
2 checks passed
@Ian2012 Ian2012 deleted the cag/ccx-support branch February 21, 2024 13:17
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants